After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 361135 - Migrate from libgnomeui's druid to GtkAssistant
Migrate from libgnomeui's druid to GtkAssistant
Status: RESOLVED FIXED
Product: ekiga
Classification: Applications
Component: general
GIT master
Other All
: Normal enhancement
: ---
Assigned To: Ekiga maintainers
Ekiga maintainers
: 336986 (view as bug list)
Depends on:
Blocks: 329761 336986 361678 487192
 
 
Reported: 2006-10-10 13:15 UTC by Luis Menina
Modified: 2008-01-07 19:38 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
[PATCH] Replace GnomeDruid-based assistant implementation with GtkAssistant. (228.60 KB, patch)
2008-01-06 23:32 UTC, Steve Frécinaux 		none Details | Review

Description Luis Menina 2006-10-10 13:15:58 UTC 
Step 2 to GTK-only ekiga: get rid of the gnome-druid, replace it by its
GTK counterpart, GtkAssistant, available since GTK 2.10.
I'll hopefully cook a patch for this.
Comment 1 Luis Menina 2007-11-19 00:50:00 UTC 
In fact, the UI model used by ekiga is so outdated that it would require a complete rewrite, using GtkAssistant, GtkBuilder and GtkUIManager. I think it would clarify a lot the UI code. Still, I don't really understand ATM how tied it is with the configuration preferences backend...
Comment 2 Damien Sandras 2007-11-19 21:35:46 UTC 
Vincent has a preliminary patch.
Comment 3 Vincent Luba 2007-11-20 08:25:28 UTC 
As Damien said, I rewrote the UI using GtkAssistant. I'm almost done, I still have to finish the server-side account creation scripts. Didn't have much time these last weeks.
Comment 4 Luis Menina 2007-11-20 15:15:55 UTC 
*** Bug 336986 has been marked as a duplicate of this bug. ***
Comment 5 Steve Frécinaux 2008-01-06 23:32:30 UTC 
Created attachment 102293 [details] [review]
[PATCH] Replace GnomeDruid-based assistant implementation with GtkAssistant.


This matches the functionnality of the previous assistant without adding
new functionnality. It also plugs several string leaks in the previous
code.
---
 ChangeLog                             |   24 +
 configure.ac                          |    1 -
 lib/Makefile.am                       |    4 -
 lib/druid/Makefile.am                 |   19 -
 lib/druid/Readme                      |    2 -
 lib/druid/gnome-druid-page-edge.c     |  649 ------------
 lib/druid/gnome-druid-page-edge.h     |  158 ---
 lib/druid/gnome-druid-page-standard.c |  788 ---------------
 lib/druid/gnome-druid-page-standard.h |  123 ---
 lib/druid/gnome-druid-page.c          |  412 --------
 lib/druid/gnome-druid-page.h          |  133 ---
 lib/druid/gnome-druid.c               | 1051 --------------------
 lib/druid/gnome-druid.h               |  141 ---
 src/Makefile.am                       |    4 +-
 src/devices/audio.cpp                 |   29 +-
 src/devices/videoinput.cpp            |   14 +-
 src/endpoints/ekiga.cpp               |   14 +-
 src/endpoints/ekiga.h                 |    6 +-
 src/gui/assistant.cpp                 | 1159 ++++++++++++++++++++++
 src/gui/assistant.h                   |   78 ++
 src/gui/conf.cpp                      |    2 +-
 src/gui/druid.cpp                     | 1736 ---------------------------------
 src/gui/druid.h                       |   66 --
 src/gui/main.cpp                      |   16 +-
 24 files changed, 1300 insertions(+), 5329 deletions(-)
Comment 6 Damien Sandras 2008-01-07 19:38:48 UTC 
Patch applied to TRUNK.

Thanks a lot !