After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 351730 - Keep findbar open when opening links in new tabs
Keep findbar open when opening links in new tabs
Status: RESOLVED OBSOLETE
Product: epiphany
Classification: Core
Component: Interface
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
Depends on:
Blocks: 755518
 
 
Reported: 2006-08-17 08:26 UTC by Wouter Bolsterlee (uws)
Modified: 2018-08-03 19:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Leaves find bar open when clicks are open in new tabs (1.03 KB, patch)
2006-11-04 00:17 UTC, Diego Escalante Urrelo (not reading bugmail)
rejected Details | Review

Description Wouter Bolsterlee (uws) 2006-08-17 08:26:14 UTC
The findbar should be kept open when a link is opened in a new tab.

(This bug report is based on comment #11 in bug #332349)
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2006-11-04 00:17:42 UTC
Created attachment 75979 [details] [review]
Leaves find bar open when clicks are open in new tabs

This makes what the bug ask for.
However, when the new tab is open the find bar loses focus (no matter that gtk_widget_grab_focus()). I'm not sure how to avoid this, let's see if someone has a better idea.
Comment 2 Christian Persch 2006-11-04 10:32:06 UTC
IMHO it's problematic that you can then only close the findbar by focusing it and defocusing it again, which is not really discoverable...
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2006-11-04 20:44:30 UTC
Yes, when you try the patch it's a whole different opinion you get. I didn't like it that much.
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2006-12-02 05:14:39 UTC
Wouter, I think this is a WORKSUGLY bug. At least the way I implemented it. Can you give this patch a try?.
Comment 5 Wouter Bolsterlee (uws) 2006-12-05 12:48:12 UTC
Perhaps we should give this some more UI though before applying random patches to change the current behaviour...
Comment 6 Christian Persch 2007-01-29 21:48:45 UTC
Since this patch breaks the find bar's focus model, I'm going to reject it.
Comment 7 GNOME Infrastructure Team 2018-08-03 19:16:18 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/epiphany/issues/109.