After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 349308 - Help kill libegg
Help kill libegg
Status: RESOLVED WONTFIX
Product: deskbar-applet
Classification: Deprecated
Component: general
unspecified
Other Linux
: High critical
: ---
Assigned To: Deskbar Applet Maintainer(s)
Deskbar Applet Maintainer(s)
gnome[unmaintained]
Depends on: 413538
Blocks: 349256
 
 
Reported: 2006-07-30 12:35 UTC by Vincent Untz
Modified: 2011-07-10 02:24 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Vincent Untz 2006-07-30 12:35:16 UTC
+++ This bug was initially created as a clone of Bug #349256 +++

Please help kill libegg. Your module contains some egg code that is now deprecated thanks to new features, most probably the new GTK+ 2.10 features like:

 + GtkRecent* (deprecating EggRecent)
 + GtkStatusIcon (deprecating EggTrayIcon and EggStatusIcon)
 + GtkCellRendererAccel (deprecating EggCellRendererKeys)
 + GtkAccelGroup now has features to deprecate EggAccelerator (see bug 85780)

Also, egg-screen-exec stuff has been deprecated: see http://cvs.gnome.org/viewcvs/*checkout*/libegg/libegg/screen-exec/README

Also, EggIconList has become GtkIconView in GTK+ 2.6.
Comment 1 Raphael Slinckx 2006-08-23 14:31:57 UTC
I don't really see what code you are talking about, to be honest ?
Comment 2 Johan Svedberg 2006-08-23 14:34:44 UTC
It's the keybinder code from tomboy.
Comment 3 Raphael Slinckx 2006-08-23 14:47:05 UTC
Ah thanks
Comment 4 Jared Moore 2007-06-11 08:35:50 UTC
I'd be willing to work on this, although it will require a gtk+ >= 2.10 dependency. Thoughts?
Comment 5 Sebastian Pölsterl 2007-09-01 10:46:02 UTC
As of Deskbar-Applet 2.20 the minimum GTK+ version will be 2.10.
Comment 6 Johan Svedberg 2007-09-01 10:57:04 UTC
There is now, thanks to Bastien, a way to register keybindings in gnome-keybindings-properties. It needs control-center 2.20 though, see http://live.gnome.org/ControlCenter/ApplicationDefinedKeybindings.

You still need the relevant code to listen for the hotkeys, but Bastien mentioned he might be looking at fixiing this aswell. Just so you can sync your work.
Comment 7 Sebastian Pölsterl 2007-09-01 11:02:53 UTC
See bug #413538. The problem is it doesn't actually bind the key, but only stores the keybinding.
Comment 8 Johan Svedberg 2007-09-01 11:08:58 UTC
Yes, I know. Just thought it would be good for Jared to know that Bastien might already started working on binding functionality.
Comment 9 Sebastian Pölsterl 2008-03-13 11:21:13 UTC
Any update on this issue?
Comment 10 Jared Moore 2008-03-13 23:31:22 UTC
Sorry but I haven't been working on it, if that's what you mean.
Comment 11 Debajyoti Bera 2008-03-31 02:34:19 UTC
Maybe we should all start using gtkhotkey :) Has anyone tried it ? It currently uses the same Tomboy code that everyone else is using, so it should "just work".

http://www.grillbar.org/wordpress/?p=250
Comment 12 Sebastian Pölsterl 2008-03-31 10:05:31 UTC
(In reply to comment #11)
> Maybe we should all start using gtkhotkey :) Has anyone tried it ? It currently
> uses the same Tomboy code that everyone else is using, so it should "just
> work".
> 
> http://www.grillbar.org/wordpress/?p=250
> 

That looks very promising. Telling from the comments, it still includes the libegg stuff we want to get rid of?

(CCing Mikkel Kamstrup hoping that he can provide some inside)
Comment 13 Mikkel Kamstrup Erlandsen 2008-04-03 11:28:08 UTC
As such libegg code is not "bad" code as such. It just needs to go in a coherent context and lose the egg namespace.

Ofcourse we also need to remove as much duplicate code as possible - the eggaccelerators code I use is partly doubled in Gtk+ now. I will look at removing all duplicate code for the next gtkhotkey release.

The API og gtkhotkey is clean so we can easily clean up the bottom as we go.

GtkHotkey is not Gnome-only, but since it uses interfaces and abstract factories for all parts is should be quite clean to integrate with http://live.gnome.org/ControlCenter/ApplicationDefinedKeybindings. The only tricky point can be if the data models does not map cleanly.

Anyways I can not work on GtkHotkey before xesam-glib 0.2 is out, this will take a few weeks at minimum. I will follow up here when I pick up GtkHotkey. Else feel free to check out the code... Hint hint.
Comment 14 Mart Raudsepp 2008-04-24 17:50:46 UTC
Please don't clutter the Gtk namespace with GtkHotkey*. It belongs to gtk+, not an outside add-on library. Instead, this could be proposed and integrated into gtk+-2.14, in which case it should be in the gtk+ namespace, otherwise not. That's my personal opinion though.
If libgtkhotkey is used in its current API in deskbar-applet, then all hell will break loose when the user upgrades gtk+ to a version that has GtkHotkey itself (assuming it will).
Comment 15 André Klapper 2009-05-18 07:16:43 UTC
...any news here after more than one year?
Comment 16 Sebastian Pölsterl 2009-05-18 09:20:24 UTC
As long as bug #413538 is still open this one is too. I'm not aware of any progress, though.
Comment 17 Javier Jardón (IRC: jjardon) 2010-04-17 14:57:09 UTC
As bug #349306 is solved now, maybe you want to take a look
Comment 18 Akhil Laddha 2011-07-10 02:24:52 UTC
deskbar-applet development has been stalled [1]. Maintainers don't have future development plan so i am closing the bugs as WONTFIX.

[1] http://mail.gnome.org/archives/desktop-devel-list/2011-June/msg00073.html