GNOME Bugzilla – Bug 349265
Help kill libegg
Last modified: 2014-05-25 02:35:51 UTC
+++ This bug was initially created as a clone of Bug #349256 +++ Please help kill libegg. Your module contains some egg code that is now deprecated thanks to new features, most probably the new GTK+ 2.10 features like: + GtkRecent* (deprecating EggRecent) + GtkStatusIcon (deprecating EggTrayIcon and EggStatusIcon) + GtkCellRendererAccel (deprecating EggCellRendererKeys) + GtkAccelGroup now has features to deprecate EggAccelerator (see bug 85780) Also, egg-screen-exec stuff has been deprecated: see http://cvs.gnome.org/viewcvs/*checkout*/libegg/libegg/screen-exec/README Also, EggIconList has become GtkIconView in GTK+ 2.6.
Let's fix this for GNOME 2.20
See bug #412130 for some insight into why we haven't acted on this yet (large deployments that want to upgrade Tomboy without being forced to upgrade gtk+/gtk#). That being said, here is what needs to be accomplished: 1. Replace use of EggTrayIcon with GtkStatusIcon. This will cause us to lose the current middle-click functionality (paste into Start Here note). There might be some visual/behavior artifacts as well, since GtkStatusIcon is *not* a widget. 2. Replace use of EggAccelerator with GtkAccelGroup. This is also used in the Tomboy tray code. I haven't investigated it at all past that. Fixing these bugs will be a big help in being able to distribute Tomboy as a "pure" gtk+ app on non-GNOME (or non-Linux) platforms like Maemo, OS X, and Windows. I'd like to see a patch for fixing this, followed by a brief discussion about how to address the needs of the large deployments mentioned earlier. Aside: I'm playing with GtkStatusIcon right now, and while using Ubuntu 7.04 (GNOME 2.18 era) I experienced runtime errors with the gtk-sharp bindings. They seem to be working well since upgrading to Ubuntu 7.10 (GNOME 2.20 era). I'm just making a note of this as a reminder to test older versions of Mono and gtk-sharp.
Setting the default assignee and QA Contact to "tomboy-maint@gnome.bugs".
Created attachment 107940 [details] [review] GtkStatusIcon patch Here is a patch that replaces EggTrayIcon with GtkStatusIcon
*** Bug 520752 has been marked as a duplicate of this bug. ***
Stefan, the behavior of this patch is perfect! I'm just reviewing the code itself now, since this is kind of a messy area of Tomboy. :-)
I committed the Gtk.StatusIcon patch (with a few tweaks) in r2056. Still to do before this bug is fixed: 2. Replace use of EggAccelerator with GtkAccelGroup. This is also used in the Tomboy tray code. I haven't investigated it at all past that.
I had some trouble wrapping my head around the way EggAccelerator is used in libtomboy. Removing from managed code shouldn't cause any trouble, though.
Pushing to next cycle.
(In reply to comment #9) > Pushing to next cycle. Is this still on the list? (As the code for fixing bug 349306 and bug 349308 is similar, but one module has to push the efforts...)
Yes, the target is set as a bug to address this cycle. I hope we'll get to it, but it is not my highest priority right now. Patches welcome.
Next cycle, patches still welcome, etc.
As bug #349306 is solved now, maybe you want to take a look
Fixed 349265