After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 348191 - 'make check' fails
'make check' fails
Status: RESOLVED FIXED
Product: eel
Classification: Deprecated
Component: general
2.14.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 103964 341981 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-07-20 22:01 UTC by Дилян Палаузов
Modified: 2007-06-23 20:25 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14



Description Дилян Палаузов 2006-07-20 22:01:13 UTC
Hello,
I try to `eel-2.14.1/make check`, but it fails cause of eel_self_check_glib_externsions:

$ make check
[...]
running eel_self_check_extension

FAIL: check failed in eel-glib-extensions.c, line 1219
      evaluated: test_Strftime ("%m/%d/%y, %I:%M %p", 2000, 1, 1, 1, 0, 0)
       expected: 01/01/00, 01:00 AM
            got: 01/01/00, 01:00
[...]

The same with eel-glib-extensions.c,line 1221 and 1223).

   I consider this a bug, since the way the time is presented on the system depends on LC_TIME, while the po/* entries are generated based on LC_MESSAGES. This two do not have to coinside, as eel's "make check" supposes. And thus the tests will fail, even if there is no reason for this.
  Greetings,
   Dilian
Comment 1 Martin Wehner 2007-06-23 17:10:23 UTC
Fixed on HEAD:

2007-06-23  Martin Wehner  <martin.wehner@gmail.com>

	* eel/eel-glib-extensions.c: (eel_self_check_glib_extensions):
	Set LC_TIME="C" before testing the output of eel_strdup_strftime
	instead of having the translators to provide the expected results.
	Fixes 'make check' when LC_TIME != LC_MESSAGES. (#348191)
Comment 2 Martin Wehner 2007-06-23 17:11:20 UTC
*** Bug 341981 has been marked as a duplicate of this bug. ***
Comment 3 Martin Wehner 2007-06-23 17:12:13 UTC
*** Bug 103964 has been marked as a duplicate of this bug. ***