After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 338562 - Add move to trash support to the iPod source
Add move to trash support to the iPod source
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Removable Media
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks: 338564
 
 
Reported: 2006-04-15 08:57 UTC by Christophe Fergeau
Modified: 2006-04-16 19:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add move to trash to the iPod source (3.81 KB, patch)
2006-04-15 08:58 UTC, Christophe Fergeau 		none Details | Review
Patch against CVS HEAD (4.51 KB, patch)
2006-04-15 09:26 UTC, Christophe Fergeau 		committed Details | Review
Use a hash table to map a RhythmDBEntry to an Itdb_Track (3.11 KB, patch)
2006-04-16 10:58 UTC, Christophe Fergeau 		committed Details | Review

Description Christophe Fergeau 2006-04-15 08:57:36 UTC 
The upcoming patch enables "move to trash" in the iPod source. Moving files to the trash will freeze the UI for a few seconds though.
Comment 1 Christophe Fergeau 2006-04-15 08:58:02 UTC 
Created attachment 63545 [details] [review]
Add move to trash to the iPod source
Comment 2 Christophe Fergeau 2006-04-15 09:26:39 UTC 
Created attachment 63546 [details] [review]
Patch against CVS HEAD

The attached patch applies cleanly against CVS HEAD. The previous patch might apply on top of the patch for bug #338561 (though I haven't tested).
Comment 3 James "Doc" Livingston 2006-04-15 09:43:36 UTC 
Looks good to me.
Comment 4 Christophe Fergeau 2006-04-16 10:58:10 UTC 
Created attachment 63630 [details] [review]
Use a hash table to map a RhythmDBEntry to an Itdb_Track

This is an alternative approach to what the patch from bug #337429 would let me do. Using a GHashTable is better than what is being done atm though.
Comment 5 Christophe Fergeau 2006-04-16 19:51:59 UTC 
I committed the last patch with a change: RhythmDBEntries are now removed from teh hash table when the file is moved to trash.