After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 338561 - Add context menu to the iPod source
Add context menu to the iPod source
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Removable Media
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks: 338564
 
 
Reported: 2006-04-15 08:55 UTC by Christophe Fergeau
Modified: 2006-04-16 11:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add eject and rename context menu items (6.46 KB, patch)
2006-04-15 08:56 UTC, Christophe Fergeau 		none Details | Review
Updated patch, g_strdup the UIActions (8.19 KB, patch)
2006-04-15 10:12 UTC, Christophe Fergeau 		committed Details | Review
Changes to be done when the ipod source is pluginized (pluginified ?) (2.63 KB, patch)
2006-04-15 10:13 UTC, Christophe Fergeau 		none Details | Review

Description Christophe Fergeau 2006-04-15 08:55:58 UTC 
The attached patch adds a context menu to the iPod source with "eject" and "rename" menu items. It also marks the source as "renamable", and adds an "eject" toolbar item.
Comment 1 Christophe Fergeau 2006-04-15 08:56:40 UTC 
Created attachment 63544 [details] [review]
Add eject and rename context menu items
Comment 2 James "Doc" Livingston 2006-04-15 09:41:08 UTC 
ui manager stuff: when ipod support is a plugin, it should be done in the plugin initialisation.

impl_get_ui_actions(): as of a few days ago, the list needs to have copies of the strings, not constant ones (required to be this way for language bindings)


Apart from that, looks good.
Comment 3 Christophe Fergeau 2006-04-15 10:12:03 UTC 
Created attachment 63551 [details] [review]
Updated patch, g_strdup the UIActions
Comment 4 Christophe Fergeau 2006-04-15 10:13:20 UTC 
Created attachment 63552 [details] [review]
Changes to be done when the ipod source is pluginized (pluginified ?)
Comment 5 Christophe Fergeau 2006-04-16 11:01:15 UTC 
The first patch is in, so I'm moving the second patch to bug #338443