After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 336582 - Usage of escape key is inconsistent
Usage of escape key is inconsistent
Status: RESOLVED WONTFIX
Product: gossip
Classification: Deprecated
Component: General
0.10.x
Other Linux
: Normal normal
: ---
Assigned To: Gossip Maintainers
Gossip Maintainers
: 343496 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-03-30 07:36 UTC by Wouter Bolsterlee (uws)
Modified: 2006-05-31 17:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Wouter Bolsterlee (uws) 2006-03-30 07:36:42 UTC 
The usage of the escape key is not consistent across the application.

Main window:
1. Focus the Gossip main window
2. Press Escape
3. Main window minimizes (to tray)

Chat windows:
1. Focus a Gossip chat window
2. Press Escape
actual 3.   Nothing happens
expected 3. Chat window minimizes
Comment 1 Martyn Russell 2006-03-30 08:23:54 UTC 
I disagree with this.

The main window is a special case. Windows that close on Escape have a response of GTK_RESPONSE_CANCEL (which applies to dialogs). Escape should be used to cancel something not minimise a window in my opinion.

Note: I have adopted some windows like the preferences which use "Close" to have a GTK_RESPONSE_CANCEL recently to make sure those dialogs close on Escape. I think this is ok, but using Escape to minimise is just wrong to me.
Comment 2 Wouter Bolsterlee (uws) 2006-03-30 08:43:40 UTC 
Hmm, ok. In that case, the Escape key should not cause the main window to be hidden. IIRC, close on escape had something to do with Close vs. Cancel too...
Comment 3 Martyn Russell 2006-03-30 09:14:43 UTC 
Perhaps. I didn't want a special key to do this anyway, but Escape was agreed before it was set up.
Comment 4 Richard Hult 2006-03-30 09:32:15 UTC 
Martyn, only windows with a cancel button should have escape close them... it's in the HIG and all ;) Although we can just not care about that, I guess. We're not all that HIGgy anyway.

About the escape on the roster window thing, that's just some crack that we added since a lot of other tray-icon using apps do that and it's convenient. (I don't really like the convention though, I think it's fairly broken to minimize on escape. But I'm also very used to it and would miss it if we were to remove it).
Comment 5 Martyn Russell 2006-03-31 18:22:24 UTC 
I am closing this, since we are not going to use Escape to close chat windows.
Comment 6 Elijah Newren 2006-05-31 17:57:04 UTC 
*** Bug 343496 has been marked as a duplicate of this bug. ***
Comment 7 Elijah Newren 2006-05-31 17:57:45 UTC 
(Also discussed previously in bug 135472, for the record)