GNOME Bugzilla – Bug 330686
same songs played after reading a playlist
Last modified: 2015-03-14 12:46:29 UTC
Rhythmbox 0.9.3.1 - I read one of the new playlist provided by default (top favorites songs), I let rb play all the tracks in random order. - After rb read all the playlist, the playback stopped. - I read 5 minutes Virgin Radio in radio source (don't know if it is relevant or not, but could be) - I launched the Library in random order, Rhythmbox started to play one of the songs stored in the previous playlist (I thought it was a coincidence), I press [Next] to zap to another song, and it was another song of the previous playlist, I pressed [Next] and I was another songs of the playlist. (not finishing here ...;) - I double-cliked on a song to play it, after it was played, a song from the playlist was choose by rhythmbox ('AAAAahaaaaa !!!), I choose another song, after been played, another song from the playlist was played. So I assume there is a problem somewhere.
damn fingers
If this using shuffle, shuffle+repeat?
I assume that was only shuffle, but it was months ago, and I never saw that you posted a comment :/
I've had this exact problem often too (that shuffle plays songs recently played on playlist). It appears to still happen in 0.11.6 from debian unstable, but I'm not sure it doesn't seem to be 100% reproducible.
copy-edit: I've also often had this exact problem (that shuffle plays songs recently played on a playlist). It appears to still happen in 0.11.6 from debian unstable, but it doesn't seem to be 100% reproducible.
*** Bug 580260 has been marked as a duplicate of this bug. ***
I am able to reliably reproduce this problem. Enable shuffling and start playing a playlist. Pause playback, then begin playing another playlist. Pause playback once more, return to the original playlist (making sure to deselect all in the song list) and begin playing that playlist again. You will notice that the same song as before begins playing. However, all subsequent songs have a different order. This is on version 0.12.0.
Created attachment 287042 [details] [review] Correction to shuffle mode
Review of attachment 287042 [details] [review]: I reported the same problem here: https://bugs.launchpad.net/ubuntu/+source/rhythmbox/+bug/1363609 Rhythmbox start playing the intersection of both old and new playlist. I have a patch. Briefly: The error comes from using 'rb_shuffle_entry_added' after 'rb_shuffle_entry_removed' since the first reverse modifications done by the latter. I added a function that only adds entries without changing priv->entries_removed, this way the history is correctly modified. Regards
handle_query_model_changed already accesses the hash tables directly, so there's no need to add a new function to implement the change needed here. I've pushed a modified version of this as commit 6a2f690. Thanks for figuring this one out, and sorry it took so long to get around to applying your patch.
Review of attachment 287042 [details] [review]: .