GNOME Bugzilla – Bug 330476
Add songs to a playlist out of an existing one per drag and drop
Last modified: 2006-05-30 18:59:36 UTC
If I wanna create a new playlist, or wanna add a song to an existing playlist I can drag the song out of the library and drop it into the playlist folder. But this is only possible, if I drag it out of the library. It would be nice, if I could also drag it out of an existing playlist and drop it to another playlist. This is not possible at the moment. I also can't create a new playlist out of an existing playlist per drag and drop. I always have to choose the song out of the library.
Created attachment 59349 [details] [review] Patches Banshee.SourceView.OnDragMotion to allow songs from one playlist to be dragged into a new playlist (or existing) This simply changes one if statement to allow PlaylistSource. I did have it as an array of supported sources so plugins could add there own dnd sources but felt that was overcomplicating the issue. Oh if I patched wrong, please tell me how to do it correctly, I've never made a patch before :)
Created attachment 62981 [details] [review] Same patch against cvs Hello, Your patch was good for the bug but you have to make it against cvs not *.old Do this in the root of banshee: cvs diff -u Greetz,
(In reply to comment #2) > Your patch was good for the bug but you have to make it against cvs not *.old > > Do this in the root of banshee: > cvs diff -u Nothing wrong with doing patches against .old, as long as they're made from the source tree's root. And even then, wouldn't really be a reason to reject a good patch, as long as it applies nicely it's good. Having it from the root of the source tree is preffered though ;-)
Ah well, almost got it :p Thanks for the tweak and tips Thijs :)
Moving to the User Interface component.
Lukas' patch will cover this.
Ruben - Lukas' patch as in the child source patch? Can we close this bug?
This is indeed fixed in HEAD. Thanks for pointing that out!