GNOME Bugzilla – Bug 330452
Automatic spell check suggestions should be first level menu option.
Last modified: 2008-11-27 14:56:10 UTC
Have to drill down into a second level menu for suggest word spelling is cumbersome and inefficient. it should work like thunderbird where right clicking shows immediate list of suggested word spellings. That's one less click...the way I spell, it could be the difference between healthy wrists and carpel tunnel! :) Other information:
adding dependency
Might be a dup of bug #228594
situation has become much better because of this fix by partha and srini: http://cvs.gnome.org/viewcvs/gtkhtml/components/html-editor/popup.c?r1=1.90&r2=1.91 (fix will be included in unstable evolution 2.7.3 (gtkhtml 3.11.3) and the upcoming evolution 2.8 (gtkhtml 3.12).) so now one can choose possible spellings directly from the context menu (and not only by using the "replace" dialog), but unfortunately still at the second level (the first level is the language name which seems to be necessary, otherwise it can become confusing if many languages are enabled and the number of possible spellings increases dramatically). reassigning to gtkhtml\html-editor-control.
Bumping version to a stable release.
Is this bug still valid?
I agree with Andre that moving spelling suggestions to a per-language submenu is necessary when multiple languages are selected. But if just one language is selected, a submenu seems unnecessary. Maybe we could make the pop-up menu a little smarter. Also, if spelling suggestions were to appear in the first level of the pop-up menu, the items should say something like 'Replace With "<suggestion>"'.
Firefox does this very well. The top few guesses are at the top of the right-click menu and in bold. Having to use the cascade menu is a bit clunky when you have only one language selected.
Created attachment 123338 [details] [review] Proposed patch I like the idea of putting spell check items at the top of the menu, so I did that and added a special case for when one spell check language is selected. The special case mimics Firefox's behavior.
Created attachment 123339 [details] Screenshot: Multiple Languages Pardon the size of these...
Created attachment 123340 [details] Screenshot: One Language
Created attachment 123342 [details] [review] Revised patch Fixed a careless mistake in the original patch.
Seems fine Matt. Take to trunk. I haven't tested fully, but the screenshots are awesome.
(In reply to comment #10) > Created an attachment (id=123340) [edit] > Screenshot: One Language > Awesome work. Can we restrict the spell suggestions/size of the popup menu and include a "More suggestions" submenu for a single language and "More languages" for multiple languages?
This would be nice as well, but it should be based on a '%' max match. Instead of a blanket count :-)
For single language, I was originally considering having just such a submenu. The popup menu would include 3-5 suggestions, such that the submenu would never contain less than 3 items (because having 1 or 2 suggestions split off in a submenu seems silly). Wound up not implementing it, mostly out of laziness, but if you guys think that's a good idea I'll hack up a new patch. So... Total Suggestions # in Popup Menu # in Submenu ----------------- --------------- ------------ 3 3 0 4 4 0 5 5 0 6 3 3 7 3 4 8 3 5 ... ... ... Submenu would be invisible when Total Suggestions < 6. Or I can always tweak it to display, say, 4-6 suggestions instead of 3-5. How many suggestions is too many for the popup menu? I'm not so sure about doing that for multiple languages. If we have a "More Languages" menu, then the extra languages wind up in a secondary menu, and the suggestions for those languages wind up in a tertiary menu (hard to navigate to). That doesn't sit well with me. Seems to harm usability more than help.
This seems pretty clean to me. I don't think it's horrible to have only one item in the submenu personally. In the case of 6 suggestions, 5 in the popup and 1 in the submenu would not be too bad. One could argue that the more in the first level menu, the higher chance that there will be a match. I'll support whatever you guys pick.
Created attachment 123492 [details] [review] Adds "More Suggestions menu This implements what I described in comment #15 for the single language case. The limits are easily tunable: #define MAX_LEVEL1_SUGGESTIONS 3 #define MIN_LEVEL2_SUGGESTIONS 3 Having played around with it I'm now thinking 3 suggestions in the pop-up is too few. 4 to 6 would be better. 5 to 7 might be too many. I'll bump the limit to allow 4 to 6 when I commit, unless someone suggests an alternative.
Created attachment 123493 [details] Screenshot: One Language Illustrates the changes made in the latest patch.
Seems fine Matt, but do this have a '%' best match return? In your example, I would put 'the', 'tea' are closer than the other things. But 'the' appears last in the submenu, which might be bad. Anyways, looks cool.
Wish I could, but Enchant just hands me a list of words and nothing with which to rank them. I'd even argue that's Enchant's job, not ours. But I'll double check to make sure I haven't missed something.
Committed to trunk (revision 9054).