After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 330017 - [Patch] <object> and <iframe> tags assign height attributes incorrectly
[Patch] <object> and <iframe> tags assign height attributes incorrectly
Status: RESOLVED FIXED
Product: GtkHtml
Classification: Other
Component: Parsing
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: gtkhtml-maintainers
Evolution QA team
Depends on:
Blocks: 328114
 
 
Reported: 2006-02-05 16:55 UTC by Andreas Köhler
Modified: 2006-03-22 02:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
First try (766 bytes, patch)
2006-02-05 16:56 UTC, Andreas Köhler 		committed Details | Review

Description Andreas Köhler 2006-02-05 16:55:36 UTC 
The htmlengine seems to fail in assigning height attributes of <object>s and <iframe>s. Attached patch looks pretty straightforward to me. Any comments?
Comment 1 Andreas Köhler 2006-02-05 16:56:30 UTC 
Created attachment 58767 [details] [review]
First try
Comment 2 André Klapper 2006-02-09 20:12:22 UTC 
does this refer and did you test this for both absolute pixel values and proportional values?
also see bug 201164...
Comment 3 Andreas Köhler 2006-02-09 20:31:03 UTC 
If this was the question, it refers to bug 328114.

I do know 201164 and fortunately do not care about proportional values :) I tested the patch for absolute values (it fixes 328114) and I think (untested) that it should not hurt proportional values (where implemented).

IMHO, this is just a typo.
Comment 4 Chris Shoemaker 2006-03-19 04:47:46 UTC 
I've confirmed that this patch, when applied to 3.10.0, correctly sets both the height and width fields, instead of leaving the height field as '-1'.  Please commit.

Note: this bug looks like someone just cut-n-pasted the width handling to make the height handling but forgot to change 'width' to 'height' in those two places.
Comment 5 André Klapper 2006-03-22 02:26:05 UTC 
committed both to cvs head and to gnome-2-14 branch:
http://cvs.gnome.org/viewcvs/gtkhtml/src/htmlengine.c?r1=1.644&r2=1.645
http://cvs.gnome.org/viewcvs/gtkhtml/src/htmlengine.c?r1=1.644&r2=1.644.2.1

patch will be included in gtkhtml-3.10.1 and gtkhtml-3.11.x.

thanks for the patch and your patience.
closing as fixed.