After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 329694 - "Visual" needs translator comments
"Visual" needs translator comments
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.8.x (obsolete)
Other Linux
: Normal trivial
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on: 335814
Blocks: 236276
 
 
Reported: 2006-02-03 02:16 UTC by André Klapper
Modified: 2010-04-02 10:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Translator comments added. (1.14 KB, patch)
2006-08-24 09:48 UTC, ushveen kaur
committed Details | Review

Description André Klapper 2006-02-03 02:16:55 UTC
#: ../widgets/misc/e-charset-picker.c:103
msgid "Visual"

what shall it mean in this context?
please add translator comments:
http://developer.gnome.org/doc/tutorials/gnome-i18n/developer.html#use-comments


quoting the code here:

/* This list is based on what other mailers/browsers support. There's
 * not a lot of point in using, say, ISO-8859-3, if anything that can
 * read that can read UTF8 too.
 */
static ECharset charsets[] = {
	{ "ISO-8859-13", E_CHARSET_BALTIC, NULL },
	{ "ISO-8859-4", E_CHARSET_BALTIC, NULL },
	{ "ISO-8859-2", E_CHARSET_CENTRAL_EUROPEAN, NULL },
	{ "Big5", E_CHARSET_CHINESE, N_("Traditional") },
	{ "BIG5HKSCS", E_CHARSET_CHINESE, N_("Traditional") },
	{ "EUC-TW", E_CHARSET_CHINESE, N_("Traditional") },
	{ "GB18030", E_CHARSET_CHINESE, N_("Simplified") },
	{ "GB2312", E_CHARSET_CHINESE, N_("Simplified") },
	{ "HZ", E_CHARSET_CHINESE, N_("Simplified") },
	{ "ISO-2022-CN", E_CHARSET_CHINESE, N_("Simplified") },
	{ "KOI8-R", E_CHARSET_CYRILLIC, NULL },
	{ "Windows-1251", E_CHARSET_CYRILLIC, NULL },
	{ "KOI8-U", E_CHARSET_CYRILLIC, N_("Ukrainian") },
	{ "ISO-8859-5", E_CHARSET_CYRILLIC, NULL },
	{ "ISO-8859-7", E_CHARSET_GREEK, NULL },
	{ "ISO-8859-8", E_CHARSET_HEBREW, N_("Visual") },
	{ "ISO-2022-JP", E_CHARSET_JAPANESE, NULL },
	{ "EUC-JP", E_CHARSET_JAPANESE, NULL },
	{ "Shift_JIS", E_CHARSET_JAPANESE, NULL },
	{ "EUC-KR", E_CHARSET_KOREAN, NULL },
	{ "ISO-8859-9", E_CHARSET_TURKISH, NULL },
	{ "UTF-8", E_CHARSET_UNICODE, NULL },
	{ "UTF-7", E_CHARSET_UNICODE, NULL },
	{ "ISO-8859-1", E_CHARSET_WESTERN_EUROPEAN, NULL },
	{ "ISO-8859-15", E_CHARSET_WESTERN_EUROPEAN_NEW, NULL },
Comment 1 André Klapper 2006-03-24 14:01:25 UTC
also see bug 335814
Comment 2 André Klapper 2006-08-22 14:31:21 UTC
           To translators: Character set "Visual Hebrew"
would be a good translator comment here, but this is blocked by fixing bug 335814 first.
Comment 3 ushveen kaur 2006-08-24 09:48:32 UTC
Created attachment 71514 [details] [review]
Translator comments added.
Comment 4 André Klapper 2006-08-24 13:43:24 UTC
looks good, but should not be committed due to bug 335814
Comment 5 Srinivasa Ragavan 2006-09-29 07:56:47 UTC
Committed the fix with slight change.
Comment 6 André Klapper 2006-10-02 07:09:54 UTC
sorry, i should not have written "looks good". my fault. :-/

quoting from http://developer.gnome.org/doc/tutorials/gnome-i18n/developer.html#use-comments :
"As gettext automatically picks up all comments that happen to be **immediately preceding** a message (...)"
this is missing here.
Comment 7 Matthew Barnes 2008-03-11 00:29:15 UTC
Bumping version to a stable release.
Comment 8 Matthew Barnes 2009-02-11 05:35:50 UTC
We should add translator comments for all character sets that have variations.

e.g.  /* Translators: Character set "Chinese, Traditional" */
      { "Big5", E_CHARSET_CHINESE, N_("Traditional") },
Comment 9 Milan Crha 2010-04-02 10:42:59 UTC
As Matt suggested. Does this have anything to do with bug #304996? Maybe not.

Created commit cb41027 in evo master (2.31.1+)