GNOME Bugzilla – Bug 329694
"Visual" needs translator comments
Last modified: 2010-04-02 10:42:59 UTC
#: ../widgets/misc/e-charset-picker.c:103 msgid "Visual" what shall it mean in this context? please add translator comments: http://developer.gnome.org/doc/tutorials/gnome-i18n/developer.html#use-comments quoting the code here: /* This list is based on what other mailers/browsers support. There's * not a lot of point in using, say, ISO-8859-3, if anything that can * read that can read UTF8 too. */ static ECharset charsets[] = { { "ISO-8859-13", E_CHARSET_BALTIC, NULL }, { "ISO-8859-4", E_CHARSET_BALTIC, NULL }, { "ISO-8859-2", E_CHARSET_CENTRAL_EUROPEAN, NULL }, { "Big5", E_CHARSET_CHINESE, N_("Traditional") }, { "BIG5HKSCS", E_CHARSET_CHINESE, N_("Traditional") }, { "EUC-TW", E_CHARSET_CHINESE, N_("Traditional") }, { "GB18030", E_CHARSET_CHINESE, N_("Simplified") }, { "GB2312", E_CHARSET_CHINESE, N_("Simplified") }, { "HZ", E_CHARSET_CHINESE, N_("Simplified") }, { "ISO-2022-CN", E_CHARSET_CHINESE, N_("Simplified") }, { "KOI8-R", E_CHARSET_CYRILLIC, NULL }, { "Windows-1251", E_CHARSET_CYRILLIC, NULL }, { "KOI8-U", E_CHARSET_CYRILLIC, N_("Ukrainian") }, { "ISO-8859-5", E_CHARSET_CYRILLIC, NULL }, { "ISO-8859-7", E_CHARSET_GREEK, NULL }, { "ISO-8859-8", E_CHARSET_HEBREW, N_("Visual") }, { "ISO-2022-JP", E_CHARSET_JAPANESE, NULL }, { "EUC-JP", E_CHARSET_JAPANESE, NULL }, { "Shift_JIS", E_CHARSET_JAPANESE, NULL }, { "EUC-KR", E_CHARSET_KOREAN, NULL }, { "ISO-8859-9", E_CHARSET_TURKISH, NULL }, { "UTF-8", E_CHARSET_UNICODE, NULL }, { "UTF-7", E_CHARSET_UNICODE, NULL }, { "ISO-8859-1", E_CHARSET_WESTERN_EUROPEAN, NULL }, { "ISO-8859-15", E_CHARSET_WESTERN_EUROPEAN_NEW, NULL },
also see bug 335814
To translators: Character set "Visual Hebrew" would be a good translator comment here, but this is blocked by fixing bug 335814 first.
Created attachment 71514 [details] [review] Translator comments added.
looks good, but should not be committed due to bug 335814
Committed the fix with slight change.
sorry, i should not have written "looks good". my fault. :-/ quoting from http://developer.gnome.org/doc/tutorials/gnome-i18n/developer.html#use-comments : "As gettext automatically picks up all comments that happen to be **immediately preceding** a message (...)" this is missing here.
Bumping version to a stable release.
We should add translator comments for all character sets that have variations. e.g. /* Translators: Character set "Chinese, Traditional" */ { "Big5", E_CHARSET_CHINESE, N_("Traditional") },
As Matt suggested. Does this have anything to do with bug #304996? Maybe not. Created commit cb41027 in evo master (2.31.1+)