GNOME Bugzilla – Bug 327691
URI-bar location persists after deletion
Last modified: 2009-03-21 18:21:29 UTC
Please describe the problem: When you leave a directory for its parent using the URI-bar and then delete said directory URI-bar still shows it. Steps to reproduce: 1. Enter directory B 2. Navigate to B's parent A 3. Delete B Actual results: URI-bar still shows B. Navigating to B results in an error dialog. Expected results: URI-bar should not show non-existing uri's Does this happen every time? yes Other information:
*** Bug 327705 has been marked as a duplicate of this bug. ***
This is still happening in 2.14.
*** Bug 381844 has been marked as a duplicate of this bug. ***
Diff attached and also send to Nautilus list. This diff addresses the various stat issues created when deleting a directory or file. The navigation arrows, path bar and bookmarks are all adjusted when a file is deleted.
Created attachment 78068 [details] [review] Propsed path for bug.
Created attachment 78265 [details] [review] Updated patch.
Created attachment 78415 [details] [review] Latest with Alex's proposed changes.
Hi Gene, I had a quick look at you patch and immediately noticed that it contained a lot of irrelevant changes (whitespace, alignment, replacing x with x != NULL, comment changes etc etc). First of all, it's usually a bad idea to mix "cosmetic" changes like these with the actual change. It makes the patch harder to review, muddles up revision history, makes the patch harder to back out if it later is proven to be wrong and so on. Secondly, I don't think most of the cosmetic changes are correct. I haven't looked over the Nautilus coding guidelines in a long time but if you are to make clean ups like this, you should have a look (e.g. I think "if (x)" is preferred over "if (x != NULL)" and tab (with size set to 8) is used to indent). Anyway, this bug annoys me too. Nice to see there's a patch for it. :)
Oh, btw. If you do find code that doesn't adhere to Nautilus' coding style guidelines, I'm sure a separate patch will be gladly accepted. :)
well... two years later, now with gnome 2.20.1 but this bug is still present. why? :(
Let's mark this as a duplicate of bug 310205. *** This bug has been marked as a duplicate of 310205 ***