After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 327691 - URI-bar location persists after deletion
URI-bar location persists after deletion
Status: RESOLVED DUPLICATE of bug 310205
Product: nautilus
Classification: Core
Component: Navigation
2.13.x
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 327705 381844 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-01-19 12:45 UTC by Marcus Leyman
Modified: 2009-03-21 18:21 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
Propsed path for bug. (5.15 KB, patch)
2006-12-10 10:22 UTC, Gene Z. Ragan
none Details | Review
Updated patch. (3.42 KB, patch)
2006-12-13 07:39 UTC, Gene Z. Ragan
none Details | Review
Latest with Alex's proposed changes. (31.75 KB, patch)
2006-12-15 06:53 UTC, Gene Z. Ragan
needs-work Details | Review

Description Marcus Leyman 2006-01-19 12:45:07 UTC
Please describe the problem:
When you leave a directory for its parent using the URI-bar and then delete said
directory URI-bar still shows it.

Steps to reproduce:
1. Enter directory B
2. Navigate to B's parent A
3. Delete B



Actual results:
URI-bar still shows B. Navigating to B results in an error dialog.

Expected results:
URI-bar should not show non-existing uri's

Does this happen every time?
yes

Other information:
Comment 1 Marcus Leyman 2006-01-19 14:50:37 UTC
*** Bug 327705 has been marked as a duplicate of this bug. ***
Comment 2 Andrew Conkling 2006-04-10 22:00:26 UTC
This is still happening in 2.14.
Comment 3 Baptiste Mille-Mathias 2006-12-10 08:12:02 UTC
*** Bug 381844 has been marked as a duplicate of this bug. ***
Comment 4 Gene Z. Ragan 2006-12-10 10:22:03 UTC
Diff attached and also send to Nautilus list.

This diff addresses the various stat issues created when deleting a directory
or file.  The navigation arrows, path bar and bookmarks are all adjusted when a
file is deleted.
Comment 5 Gene Z. Ragan 2006-12-10 10:22:41 UTC
Created attachment 78068 [details] [review]
Propsed path for bug.
Comment 6 Gene Z. Ragan 2006-12-13 07:39:18 UTC
Created attachment 78265 [details] [review]
Updated patch.
Comment 7 Gene Z. Ragan 2006-12-15 06:53:12 UTC
Created attachment 78415 [details] [review]
Latest with Alex's proposed changes.
Comment 8 Martin Ejdestig 2007-06-16 13:08:35 UTC
Hi Gene,

I had a quick look at you patch and immediately noticed that it contained a lot of irrelevant changes (whitespace, alignment, replacing x with x != NULL, comment changes etc etc).

First of all, it's usually a bad idea to mix "cosmetic" changes like these with the actual change. It makes the patch harder to review, muddles up revision history, makes the patch harder to back out if it later is proven to be wrong and so on.

Secondly, I don't think most of the cosmetic changes are correct. I haven't looked over the Nautilus coding guidelines in a long time but if you are to make clean ups like this, you should have a look (e.g. I think "if (x)" is preferred over "if (x != NULL)" and tab (with size set to 8) is used to indent).

Anyway, this bug annoys me too. Nice to see there's a patch for it. :)
Comment 9 Martin Ejdestig 2007-06-16 13:12:20 UTC
Oh, btw. If you do find code that doesn't adhere to Nautilus' coding style guidelines, I'm sure a separate patch will be gladly accepted. :)
Comment 10 Ciroloco 2008-02-28 09:33:12 UTC
well... two years later, now with gnome 2.20.1 but this bug is still present. why?
:(
Comment 11 Cosimo Cecchi 2009-03-21 18:21:29 UTC
Let's mark this as a duplicate of bug 310205.

*** This bug has been marked as a duplicate of 310205 ***