After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 327107 - XMP Metadata doesn't get updated when tag is renamed
XMP Metadata doesn't get updated when tag is renamed
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Metadata
CVS
Other Linux
: Normal normal
: ---
Assigned To: Ruben Vermeersch
: 352544 (view as bug list)
Depends on: 337724
Blocks:
 
 
Reported: 2006-01-15 17:46 UTC by Ruben Vermeersch
Modified: 2007-06-30 09:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
f-spot-tag-rename-xmp-327107.diff (2.43 KB, patch)
2007-06-23 14:41 UTC, Ruben Vermeersch 		committed Details | Review

Description Ruben Vermeersch 2006-01-15 17:46:46 UTC 
When renaming a tag, the XMP Metadata in the image files is not rewritten.
Comment 1 Larry Ewing 2006-01-15 18:06:24 UTC 
yeah this case needs to be handled
Comment 2 Ruben Vermeersch 2006-04-08 16:15:18 UTC 
Adding this to my asynchronous XMP patch, doing lot's of XMP writes no longer blocks the UI with that patch, so we can actually fix this one. Will add depend when I post the patch in bugzilla.
Comment 3 Bengt Thuree 2006-04-10 04:34:21 UTC 
Perhaps you can create a bug in BugZilla already now... to inform what you are doing, and let other people know of it, so no duplications...
Just a thought..
Comment 4 Ruben Vermeersch 2006-04-10 07:46:46 UTC 
It has been created, a patch with a fix is in bug 337724. I've added a dependency on that bug to this one. Unfortunately, bugzilla doesn't really show it when a dependency is added.

The fix is there though, no worries :-).
Comment 5 Ruben Vermeersch 2007-06-23 14:41:26 UTC 
Created attachment 90523 [details] [review]
f-spot-tag-rename-xmp-327107.diff

This patch should fix it, uses the now committed scheduler. Anyone care to review it?

Let me know if it's ok to commit this.
Comment 6 Ruben Vermeersch 2007-06-23 14:42:57 UTC 
Oh, for the record: I've removed the stray Console.WriteLine in my working tree, just noticed it's still there in the patch.
Comment 7 Ruben Vermeersch 2007-06-30 09:24:17 UTC 
After a week of using it, it seems to work flawlessly. I've pushed my changes to trunk (it seems both sde and lewing have fallen of the earth and I don't like bitrot).
Comment 8 Ruben Vermeersch 2007-06-30 09:55:23 UTC 
*** Bug 352544 has been marked as a duplicate of this bug. ***