GNOME Bugzilla – Bug 326608
Download appears to never finish when saving about:blank
Last modified: 2009-12-14 08:11:42 UTC
Noticed when looking at bug 325624, if you go to about:blank and go Save As, the file downloads but the downloads dialog remains with the entry "0%, Untitled 0 bytes of 0 bytes, Remaining: 00:00" In case it's useful, the file downloaded is 118 bytes -- perhaps the downloader gets confused with stuff that's really small?
So in MozDownload::OnStateChange, we get a STATE_STOP | STATE_IS_NETWORK, which isn't passing our check for STATE_STOP && STATE_IS_NETWORK && STATE_IS_REQUEST...
Not a major problem, and I don't want to change download logic on branch. We need to figure out how firefox handles this case.
Indeed, this is very much an edge case.
The same thing happens when saving other pages too if they finish fast... need to fix this.
From somewhere in the mozilla code: http://lxr.mozilla.org/aviary101branch/source/toolkit/components/downloads/src/nsDownloadManager.cpp 2043 NS_IMETHODIMP 2044 nsDownload::OnStateChange(nsIWebProgress* aWebProgress, 2045 nsIRequest* aRequest, PRUint32 aStateFlags, 2046 nsresult aStatus) 2047 { (...) 2067 // Files less than 1Kb shouldn't show up as 0Kb. 2068 if (mMaxBytes==0) 2069 mMaxBytes = 1; 2070 mCurrBytes = mMaxBytes; 2071 mPercentComplete = 100; (...) 2136 } How to get the magical mMaxBytes is a question I can't answer.
*** Bug 407939 has been marked as a duplicate of this bug. ***
What would break if I do?: - if (((aStateFlags & STATE_IS_REQUEST) && - (aStateFlags & STATE_IS_NETWORK) && + if (((aStateFlags & STATE_IS_NETWORK) && (aStateFlags & STATE_STOP)) || aStateFlags == STATE_STOP) { It seems to work here, and it didn't break anything.
Created attachment 117948 [details] [review] [PATCH] Fix small downloads staying forever in the download manager Not requiring STATE_IS_REQUEST in MozDownload::OnStateChange of MozDownload.cpp. Doesn't seem to break anything at all. Also, include a minor indentation fix. --- embed/mozilla/MozDownload.cpp | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-)
I have tried it a bit more and only thing against seems to be that downloads finishing too quick don't pop the window... for example about:blank and the google logo in its homepage. I wouldn't consider it a problem. Testing is appreciated.
Ok, turns out that the notification window is not popping for downloads that finish too fast now. Perhaps the patch is not so correct. Maybe the ff idea of counting bytes could be tried.
Reality check.
works in ephy master.