GNOME Bugzilla – Bug 322142
Recipient input field fails at commas
Last modified: 2006-08-09 05:10:32 UTC
When writing the recipients, removal of a trailing comma is broken an unnecessary difficult. Steps to reproduce: * create a new message, To: "user@host.com" * enter a comma "," after the first recipient (results in ", ") * decide not to send to others, try to remove the comma Actual results: * the first backspace removes the space only * the second backspace does *not* remove the comma, but selects the entire email address with the trailing comma ("user@host.com,") Expected behavior: * just as in 2.2.x * backspace should remove ", ", rather than the space only Notes and workaround: Moving the cursor in front of the comma and hitting del results in the very same selection of the address, and does not remove the comma, too. The only hacky workaround to actually remove the comma is to select the comma (using Shift+ArrowKey for example) and delete it. I don't expect any regular user to find out about this. Impact: High. It is way too easy to accidentially remove a recipient due that false selection, when adding a new recipient. Note: Tested this with *disabled* Auto-Completion only. Evo 2.4.1. This is a regression from Evo 2.2.x.
why should one remove that comma at all? one time done wrong, learnt that i can keep the comma at the end of the recipients field, and begun to really love evo's behaviour - though i'm using autocompletion, but should not make any difference. :-)
Why? Easy -- I found out by mistake. Dot and comma are next to each other. So a simple typo left me with "user@host, "....
uhm, ok. seems like this has not happenend to me since 2.2, thanks for clarifying. :-) *could* be a dup, will look at it later
I did not understand "Dot and comma are next to each other." But looks like a duplicate of 314997. Reopen if it i some other problem. *** This bug has been marked as a duplicate of 314997 ***
"Dot and comma are next to each other." refers to every standard keyboard. ;-) this is kind of a duplicate of bug 314997, it's just the other way round. either bug 314997 or this bug here cannot be fixed, because they contradict each other.
Nope, this is not a dupe of #314997, and it neither is the opposite of it. This issue is: Typing a comma inserts ", ". You can remove the space, but there is no easy way to remove the "," as well. The backspace key must remove ", ", not the space only. Reopening. Not a dupe, valid bug.
Sush, still targeting this for 2.4.2 ?
I feel we can move this to 2.4.3 and 2.5 Devashish, can you look at it?
2.4.3, yay :)
i think it is not that important. it would be nice to see this fixed (still valid in 2.5.91), but currently the only result is that you have to enter the address again from the beginning, which is of course annoying, but not that important and definitely not "major". (yes, i'm trying a bit to sort out priorities.) guenther, comments?
*** Bug 337102 has been marked as a duplicate of this bug. ***
again, not that important to me, see my comment 10. removing old target milestone.
It's an extremely suboptimal user interface. If you make a typo in the address, and realise only after hitting the comma, then you end up deleting the entire address when you attempt to go back and fix the typo.
i second that criticism and it sucks, however there are quite a few hundred bugs here that suck... :-/
Created attachment 69091 [details] [review] Proposed patch
'Let us not try to be over smart. Just be Predictible." If you give a comma, it adds a ', '. When you delete using BSPACE or DEL key, it just allows you to delete. No more auto sel/deletion of entire names. Just let the BSPACE key do, what it should do.
looks good can be committed.
Patch committed to cvs head.
I'm sorry I have to say this... This patch never should have been approved, let alone committed. See the 'if' clause in the patch, rigth after the '#if 0' printf blob, currently line 1210 in the code. Due to the '&& 0' in the condition, the condition never will be true. The lions share of the condition never will be evaluated, and the 'then' block never will be reached and effectively is disabled hard. This patch has to be backed out from the code immediately and a proper fix needs more work. REOPENing. Also, is there any reason a fix for a 'major' classified bug is not being committed to the stable branch as well?
Guenther, My bad. I uploaded a wrong patch, instead of the right one. The code has to be skipped. Ill commit the right one. Guenther, Hmm, there is no UI/String break, it potentially can go in.
Hi, I've been tracking this bug for Fedora. Did the correct patch ever get committed and released? I'm running Evo 2.7.90 right now and can't reproduce the backspace behavior.
Correct patch has been committed to both head and stable.