GNOME Bugzilla – Bug 321640
Forward As menu missing
Last modified: 2013-09-10 13:56:06 UTC
The Forward As menu is missing, although Evo still got the feature of using different forward methods. Everything still is in place, just the menu itself is missing. As Evo can handle this, the user should have the option to easily choose on a case by case basis. Assume, this is an oversight due to the menu restructuring. Regression.
Created attachment 54832 [details] [review] patch to fix this This patch gets the options back in. Yay.
As this is a regression and a minor (minimal) UI change only, this should go in into 2.4.2.
adding dep, keywords, "you know the game(TM)". (damn. i shouldn't have closed about two bugs about the same issue before with the same wrong argumentation i just used on the mailing list :-/ )
Karste: A few thigns about the patch 1) Missing ChangeLogs 2) Already there is a menu-item "Forward" which needs to be removed. 3) "Ctrl+F" will activate the above menu-item which is "Forward as attachment". So, the other accelerator ctrl+J should be changed to this in the "forward as" submenu.
2) No, this does *not* need to be removed. The patch correctly re-establishes the available options, as it was available in any previous version. MessageForward uses the user defined default forwarding method (see Preferences), whereas the ForwardAs sub-menu offers all available forwarding methods on a case by case basis. 3) No, again -- for the very same reason. The accelerator Ctrl-F will use the default forwarding method the user chooses in the Preferences. I will attach a revised patch with ChangeLog and some clean-ups shortly.
this will break string translations, at least "F_orward as" is not included in the german po file in the gnome-2-12 branch. :-/ looks like 2.5 to me. now playing around with severity and priority. ;-p
I agree with sanker on Comment #4 (sub point 2). Having both Forward and ForwarAs i feel is redundant. But then again, what would the accelators be?? sigh! ui decisions are tough to make.
I guess, the feature is right. Forward does the default operation. And you can select the specific operation too. We shouldnt remove the Forward menu And Forward As is required for specific. In case, if the Default Forward isnt present, then what sankar said, could have made sense. I would say, we should accept this patch, and Contol+F should invoke the default forward method selected. We can look for some unique accelerators for Other types, but then we can decide on whether they are really required. I feel it is not really required. ** For evolution 105/110/115 key keyboards arent sufficient ;-)
Ok. I guess the patch goes in then. Guenther?? (committing it??)
Yes, we *do* need both. Forward is the user defined default forwarding method. This needs to stay in, and it needs an accelerator. The Forward As sub-menu enables the user to actually choose. FWIW, as I mentioned earlier: This is exactly, how it was in any previous version. Regarding accelerators: I don't even know, if any method needs its own accelerator, as it is already accessible by menu keyboard shortcuts. And the user defined default has it's very own anyway, using an easy to remember accelerator. Please note though, that this partch does *not* define accelerators. Those *still* are defined in the XML file. This never got out. Any thoughts on getting rid or changing these accelerators is not the topic here. This is neither the right bug, nor the right time. :) Do you guys still want me to privide a revised (cleaned up) patch with ChangeLog? Can do that tomorrow, if requested. BTW, I can't commit myself, as I'm still waiting for my CVS account.
Karsten, An accelerator is reqd for just the default options and not for other, i suppose. So just put up a reworked patch with changelog to fix these, its sufficient. As i see the xml file. <cmd name="MessageForward" _tip="Forward the selected message to someone" accel="*Control*f" pixtype="pixbuf"/> <cmd name="MessageForwardAttached" _tip="Forward the selected message to someone as an attachment" accel="*Control*j"/> <cmd name="MessageForwardInline" _tip="Forward the selected message in the body of a new message" accel="*Control**Shift*j"/> <cmd name="MessageForwardQuoted" _tip="Forward the selected message quoted like a reply"/> You aleady have things define for all except quoted. Try find a accel unique that is not used and add it for Quoted and add it to your patch, that should be fine.
NO, I am NOT going to add an accelerator. This is NOT what this bug is about. This bug is about to get back the missing sub-menu, that apparently was removed by accident. This bug is about fixing a regression. This bug is about giving the user back the options he wants and had in any previous release. This bug is NOT about adding a new accelerator. The accelerators did not change. They where not removed either. They are the very same, as they are in any previous release. They are going to stay just like they are. If you want to change the accelerators, file a NEW bug.
Created attachment 55093 [details] [review] revised patch, added ChangeLog
Sorry for the rant. :-/ A revised and cleaned up patch is attached, ChangeLog added. This one fixes the bug. This patch uses the accelerator as already defined, no changes here. If the special accelerators are removed, or if you want yet another one for ForwardQuoted can be decided later. IMHO we don't need any of 'em beside Ctrl-F for the default forwarding method. Basically, see comment #10.
I approve it. Partha, can you commit it, i guess guenther is not having commit rights.
Committed to head on behalf of guenther, since he does not have commit rights.
*** Bug 329190 has been marked as a duplicate of this bug. ***
Yup, it is in CVS. :) Adjusting patch status. *sigh*
*** Bug 336335 has been marked as a duplicate of this bug. ***