After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 317102 - CD icons should have a 16x16 variant
CD icons should have a 16x16 variant
Status: RESOLVED FIXED
Product: adwaita-icon-theme
Classification: Core
Component: general
2.12.x
Other Linux
: Normal normal
: ---
Assigned To: Jakub Steiner
Jakub Steiner
Depends on:
Blocks:
 
 
Reported: 2005-09-24 12:11 UTC by Sebastien Bacher
Modified: 2006-04-28 15:18 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12



Description Sebastien Bacher 2005-09-24 12:11:34 UTC
The issue is described by http://bugzilla.ubuntu.com/show_bug.cgi?id=16201

"I'm not sure whether to report on gnome-icon-theme or gnome-applets. This is on
the latest breezy (24-09-2005).

I have actually two problems:

1. In all the themes the disk mounter popup pops up too low. see first
screenshot attachment i'll join.

2. in the clearlooks theme disk icons don't seem to be the same size. in the
second screenshot the CD one seems bigger than the others.

http://bugzilla.ubuntu.com/attachment.cgi?id=4039
what i meant by "the popup is too low"

http://bugzilla.ubuntu.com/attachment.cgi?id=4040
what i meant by "the CD icon is bigger than the others

http://bugzilla.ubuntu.com/attachment.cgi?id=4043
this CD icon is bigger

it seems that part of the problem is that that CD icon is bigger than the other
icons. see that the location bar of nautilus is bigger on the location of that
CD than for instance on the desktop (more pixels vertically)."
Comment 1 Jakub Steiner 2005-09-26 10:20:07 UTC
Gnome icon theme doesn't have the ridiculous labels for the specific media types
at 16x16, so I'm guessing 24x24 versions get used. 

I prefer dropping all the specific media type icons completey rather than adding
the tiny silliness at 16x16 or add another set of hard to maintain symlinks.
Comment 2 Emmanuel Touzery 2005-09-29 11:43:04 UTC
is it already too late to fix it for 2.12.1? because on the drivemount applet,
it really doesn't look nice and many people use it.
Comment 3 Sebastien Bacher 2005-09-29 13:13:50 UTC
if 16x16 variant are an issue maybe you could set a variant a Scalable to not
get suchs bugs?
Comment 4 Emmanuel Touzery 2005-09-29 13:19:59 UTC
to sebastien bacher: if i understand right, the problem is that several such new
files are needed.
whether those files are 16x16 PNGs of a CD without label or SVG, there need to
be the same number of them, identical (which is complicating, to keep them up to
date) or symlinked to each other, but Jakub Steiner complains that symlinks are
complicated to maintain.

so if i understood right svg can't help. only making an icon "inheriting" to
another one or symlinks could help (or removing altogether those new specific CD
types, but i guess it's excluded for 2.12.x).
Comment 5 Sebastien Bacher 2005-09-29 13:39:15 UTC
if you set a category as Scalable you don't have this issue, the icon has the
size requested
Comment 6 Jakub Steiner 2005-09-29 14:31:11 UTC
Sebastien: even with SVG, having a single artwork for all sizes does not work.
More on this at http://jimmac.musichall.cz/weblog.php/Artwork/ScalableIcons.php
Comment 7 Jakub Steiner 2005-09-29 14:39:58 UTC
So if you want a short term solution to this bug, feel free to add the symlink
voodoo to the Makefiles to symlink all the different cd media to gnome-dev-cdrom.
Comment 8 Sebastien Bacher 2005-09-29 16:27:59 UTC
thanks. What would you consider the real fix to get icons going well on a small
panel?
Comment 9 Jakub Steiner 2005-09-29 19:14:46 UTC
The real fix would be a generic name inheritance framework. Rodney Dawes is
working on something as part of the new icon naming spec. 

What we need is for icons to have a fallback. Something like the mimetype
fallback - if there is no audio/sound, an icon for audio is used. We need
something that would say that media-cd-cdrw has a fallback of media-cd or
device-ipod-nano has a fallback of drive-removable. 

That way somebody could create a very specific icon for individual device or
mimetype, but creating a new consistent looking theme would not be a pain. More
importantly maintaining it (with all the different resolutions too) wouldn't be
such a pain. Such theme could start by addresing the generic icons. Do we need
to have an icon for every bloody mime type on the planet? We do not. But if
somebody wanted to create an icon for application/x-oh-i-just-made-this-neat-app
to easily distinguesh its files among others, (s)he may. Same for devices.
generic removable drive or media is just fine for most cases, but it may be nice
to have a custom ipod icon, or iriver icon. REQUIRING to have one is insane.
Just take a look at the size of the gnome icon theme. 
Comment 10 Emmanuel Touzery 2005-10-15 19:35:09 UTC
If some people are interested, and since the flaw is present on released
distributions, like ubuntu 5.10, i made a small personal icon theme that
contains the missing 16x16 CD icons and also the missing 48x48 ruby icon (bug
#16064).

You can get it at:
http://razor.arnes.si/~shvali/mygnomeicons.tar.gz [5.4kb]

It inherits the gnome icon theme, only makes the needed changes. To use it,
extract the .tar.gz in your ~/.icons and choose the new icon theme "MyGnome" in
system->preferences->theme->theme details->icons.
Comment 11 Jakub Steiner 2005-10-15 21:31:57 UTC
The 48x48 ruby icon is fine for addition to gnome icon theme, as long as the
author is willing. You didn't draw that icon, Emmanuel, did you?
Comment 12 Emmanuel Touzery 2005-10-16 07:15:20 UTC
Actually I got it from:
http://bugs.gnome.org/show_bug.cgi?id=160733#c2

it appears to come from
http://rox-ruby.sourceforge.net/cms.php/icons

Maybe metnik@inmail.sk who mentionned it first knows more.
I also found this, a request to include that icon in debian:
http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/2004-June/005071.html
but it mentions the license is not explicit.

at http://sourceforge.net/projects/rox-ruby/
i found that the project maintainer is geoff_youngs at users.sourceforge.net
i'll mail him asking for the license and permission. i'll post news here.
Comment 13 Emmanuel Touzery 2005-10-17 06:41:07 UTC
About the ruby icon, I'll answer more on bug #316978
Comment 14 Jakub Steiner 2005-10-17 14:14:56 UTC
The icon is fairly nice. Would it be possible to get it without the label? It's
not the same font as the gnome icon theme icons and I'd rather for it to say RB.
Comment 15 Emmanuel Touzery 2005-10-21 18:12:53 UTC
Actually the original author just sent me the SVG versions of those ruby logos.
The author and copyright holder Geoff Young is OK for you to use the original
SVG and modify them as much as you want to put them in the GNOME icon set.
The SVG for both icons are at:
http://www2.arnes.si/~shvali/ruby-red.svg [first version]
http://www2.arnes.si/~shvali/ruby.svg [better version, in the opinion of the author]
Comment 16 Jakub Steiner 2005-10-22 08:58:22 UTC
Thanks for the assistance, Emmanuel. Fixed in HEAD.

2005-10-22  Jakub Steiner <jimmac@ximian.com>

	* gnome-mime-application-x-ruby.png: based on artwork by Geoff
	  Young. Fixes bug # 317102
Comment 17 Emmanuel Touzery 2005-10-29 17:35:21 UTC
> gnome-mime-application-x-ruby.png: based on artwork by Geoff
>	  Young. Fixes bug # 317102

no, please don't close this bug, this bug has nothing to do with ruby. this
bug's title is "CD icons should have a 16x16 variant" and that problem is not
fixed. the problem is we started to discuss that new ruby icon in this bug which
concerns another problem.
you can close bug #316978 "icon for ruby programs ugly" but please reopen bug
#317102. sorry for the confusion.
Comment 18 Jakub Steiner 2005-10-29 19:24:52 UTC
Oops, sorry got it all mixed up.
Comment 19 Rodney Dawes 2006-04-24 18:44:18 UTC
This is fixed in HEAD/2.15.1. There's updated media-cdrom and drive-cdrom icons included there.
Comment 20 Daniel Holbach 2006-04-28 14:24:56 UTC
Does this mean, there'll be no 2.14.x release?
Comment 21 Rodney Dawes 2006-04-28 15:18:27 UTC
There are no plans to release any more 2.14.x versions of gnome-icon-theme, no.