After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 313847 - Drivemount consistently crashes when select drive
Drivemount consistently crashes when select drive
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: Disk Mounter (drivemount)
git master
Other All
: High critical
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-08-18 15:28 UTC by Trent "Lathiat" Lloyd
Modified: 2006-02-22 00:59 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12

Attachments
rawr (2.54 KB, patch)
2005-08-19 19:40 UTC, Allison Karlitskaya (desrt) 		none Details | Review

Description Trent "Lathiat" Lloyd 2005-08-18 15:28:42 UTC 
Steps to reproduce:
I click on my windows drive, mounted /dev/hda1 on /media/windows

Crashing does not happen with my CD/DVD drive.

Stack trace:

+ Trace 62527

  • #0 gnome_vfs_drive_get_mounted_volumes
    at gnome-vfs-drive.c line 306
  • #1 drive_button_ensure_popup
    at /build/buildd/gnome-applets-2.11.91/./drivemount/drive-button.c line 838
  • #2 drive_button_button_press
    at /build/buildd/gnome-applets-2.11.91/./drivemount/drive-button.c line 224
  • #3 _gtk_marshal_BOOLEAN__BOXED
    from /usr/lib/libgtk-x11-2.0.so.0
  • #4 g_cclosure_new_swap
    from /usr/lib/libgobject-2.0.so.0
  • #5 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #6 g_signal_stop_emission
    from /usr/lib/libgobject-2.0.so.0
  • #7 g_signal_emit_valist
    from /usr/lib/libgobject-2.0.so.0
  • #8 g_signal_emit
    from /usr/lib/libgobject-2.0.so.0
  • #9 gtk_widget_activate
    from /usr/lib/libgtk-x11-2.0.so.0
  • #10 gtk_propagate_event
    from /usr/lib/libgtk-x11-2.0.so.0
  • #11 gtk_main_do_event
    from /usr/lib/libgtk-x11-2.0.so.0
  • #12 _gdk_events_queue
    from /usr/lib/libgdk-x11-2.0.so.0
  • #13 g_main_context_dispatch
    from /usr/lib/libglib-2.0.so.0
  • #14 g_main_context_check
    from /usr/lib/libglib-2.0.so.0
  • #15 g_main_loop_run
    from /usr/lib/libglib-2.0.so.0
  • #16 bonobo_main
    from /usr/lib/libbonobo-2.so.0
  • #17 bonobo_generic_factory_main_timeout
    from /usr/lib/libbonobo-2.so.0 

Other information:
Comment 1 Trent "Lathiat" Lloyd 2005-08-18 15:29:30 UTC 
As a note, this is reliable and happens every time, happy to help with any
further debugging information.
Comment 2 Allison Karlitskaya (desrt) 2005-08-19 19:30:57 UTC 
This regression was introduced by attachment 48517 [details] [review] in bug 308388 (comment #16).

The code inserted into drive_button_ensure_popup is improperly shielded from the
case that self->drive might be NULL.
Comment 3 Allison Karlitskaya (desrt) 2005-08-19 19:40:36 UTC 
Created attachment 50998 [details] [review]
rawr

here's a patch that moves around the code a bit so that the extra checks are
done only if self->drive is non-null.

Trent: I'd appreciate it if you could test this out and see if it's OK since I
can't reproduce the bug locally.

feedback also appreciated from all other sources since I'm not familiar with
this code at all.
Comment 4 Allison Karlitskaya (desrt) 2005-08-19 19:41:20 UTC 
Emmanuel: please look this over, since it's your code.
Comment 5 Emmanuel Touzery 2005-08-20 09:45:06 UTC 
yes, that patch looks totally correct and it doesn't seem like it could break
anything (I didn't test it though). sorry that i overlooked that issue... thanks
for fixing it!
Comment 6 Allison Karlitskaya (desrt) 2005-08-22 17:01:44 UTC 
Committed to CVS HEAD.
Comment 7 Trent "Lathiat" Lloyd 2005-08-22 20:31:08 UTC 
I've confirmed the patch works with ubuntu breezys gnome applets
Comment 8 Nickolay V. Shmyrev 2006-02-22 00:59:36 UTC 
*** Bug 323359 has been marked as a duplicate of this bug. ***