GNOME Bugzilla – Bug 309964
renaming a file in listview filename jumps out of window
Last modified: 2006-03-18 12:37:10 UTC
if you are in listview with some columns not in the visible area of the window(size,mimetype,date) and a too large column for the name(by default the name field is expanded to fit the longest name in folder). now you press F2 to rename a file, the visible area is changed in a way that the next column is visible, but the begining of the area you are about to write to(name column) is not. it would be better if the visible area would not change at all.
Thanks for your bug report! I can reproduce this issue.
Created attachment 48949 [details] [review] Proposed patch against HEAD. I've also submitted this patch to the nautilus mailing list [1] for review. [1] http://mail.gnome.org/archives/nautilus-list/2005-July/msg00116.html
commited a different fix that doesn't set use_align.
*** Bug 132785 has been marked as a duplicate of this bug. ***
*** Bug 314394 has been marked as a duplicate of this bug. ***
From bug 313535: "If, in the list view, the "Name" column is wider than the nautilus window's area for the list view, nautilus makes renaming a file/folder difficult by centering the column in such a way that the editable text gets actually obscured". Maybe we should rather use my original patch which has use_align set to TRUE. I think this will do the job for this case as well.
*** Bug 313535 has been marked as a duplicate of this bug. ***
Why not just delete the entire line that uses use_align, that seems to work fine on my system.
Camilo: I suppose without this use_align, it wouldn't work correctly if the name column is smaller than the window width.
> Why not just delete the entire line that uses use_align, Do you mean we should remove the gtk_tree_view_scroll_to_cell call?
Christian: Not sure how it wouldn't work correctly, I really don't see anything wrong with not having the call at all. And yes it's the gtk_tree_view_scroll_to_cell call that I'm talking about. The one that appears on your patch to be precise, I should attach a patch but I don't know how to do that, do you have any pointers on how I can post one?
Created attachment 51741 [details] [review] [PATCH] fm-list-view.c fm-list-view.c code nautilus-2.10.1
Comment on attachment 51741 [details] [review] [PATCH] fm-list-view.c Here is a patch of the changes that I speak of. I am using nautilus-2.10.1 code.
If you don't have the scroll_to_cell call then things break if the file to be renamed is not visible. This happens for instance if the window is scrolled to the right so that the name is not fully visible. I think this also happens in the case where renames are triggered automatically, and the file isn't visible, such as the initial rename when you create a new file. Christian: Your original patch used set_align with both a row and a column alignment, this means the list *always* scrolls, even if the name is already visible, which is pretty weird. Maybe we can use set_align and scroll only horizontally.
Yes, that worked better: 2005-10-19 Alexander Larsson <alexl@redhat.com> * src/file-manager/fm-list-view.c (fm_list_view_start_renaming_file): Scroll into view correctly when renaming (#309964)
*** Bug 320009 has been marked as a duplicate of this bug. ***
*** Bug 324454 has been marked as a duplicate of this bug. ***
*** Bug 334941 has been marked as a duplicate of this bug. ***