GNOME Bugzilla – Bug 307443
HIGify remove account dialog
Last modified: 2013-09-10 14:04:48 UTC
Distribution/Version: Ubuntu 5.4 When clicking the Remove button on the Mail Accounts preferences page, the dialog box uses the terminology Delete instead of Remove (inconsistent with the previous button I had to click to show this dialog) and the buttons are in the wrong order: the affirmative button (probably titled Remove) should be on the right and the negative button (probably titled Cancel) should be on the left. As I understand the HIG, the dialog box should also not have a window title. Quite similar to bug 248135 which might have been wrongly WONTFIXed in Gnome 1.4.
adding keywords, would require string changes.
Created attachment 48304 [details] [review] Proposed patch This patch is rather simple and implements the changes needed to bring the dialog in line with the HIG (removes title, uses 'remove,' and re-orders buttons).
Apologies for any spam... cc'ing usability-maint on all Evolution usability bugs. Filter on EVO-USABILITY-SPAM to ignore.
terry, the patch is fine. Can we have a better title, instead removing it. Just put a better title. Apart from that it looks better to commit.
Looking at bug 165132, which discusses the part of the HIG that covers alert dialogs and titles, I would argue that this dialog should not have a title. I can't think of one that wouldn't be redundant.
still not included in 2.7.3. let's shorten the title to "Remove this account?" and commit. we also have to fix the same string with "delete all its proxies".
Created attachment 69182 [details] [review] enhanced patch i enhanced the former patch to hopefully fix all issues - i also vote for keeping the title, though it is a HIG violation. perhaps one should file a bug against HIG. :-)
in the current evolution, the button to the right of the mail accounts list in the preferences says "Delete". so we cannot have a "Delete" button, and then have all the following dialogs with "remove" in them.
Created attachment 69184 [details] [review] patch, another one this patch also changes the "delete" button to a "remove" button right to the account list. no idea about the HIG, though. delete vs remove? comments welcome.
"Delete" should generally be used whenever the removal is permanent, which sounds like the correct term here. "Remove" is really only useful where, for example, you have two lists between which you can move items using "Add>>" and " <<Remove" buttons.
As a general note, please do not remove title text from windows that show up in the window list. Of course, I think the whole lack of window titles and such here is something in the HIG that needs plenty of reworking. It doesn't seem to actually make sense anywhere in our desktop.
I second Calum's thoughts. We need to have DELETE every where in the a/c deletion, since that is permanent.
quoting from the usability mailing list: "http://developer.gnome.org/documents/style-guide/gnome-glossary-user-actions.html as Calum said in comment #10, "delete" is for permanent actions, while "remove" is for things that could be re-added." anyway. okay. bug report: calum, srini: delete. usability list: shaun: remove. shawn: delete. so it seems like we should use delete. shaun also wrote: "A better choice would be "Remove the settings on this computer that allow Evolution to access this account"". i'm going to add another patch here later.
Remove seems more appropriate to me, given calum's explanation. The account settings can definitely be readded. That is what the "Add" button in the account prefs page is for. It seems like this is a better explanation, and taking into account metaphors which we are trying to convey with the icon theme: Remove: Displacing an item from a list. The item may be re-added by the user at a later time, if the user chooses to do so. Delete: This item will be removed permanently. The item is a file on disk, or some other similar piece of data that will not be easily recoverable. A user may delete a text file, and create a new one of the same name, adding the same content, but this is not the same as removing and re-adding something to a list, or recovering something from trash. Trash (Move To, Recover From): This is for items which may be automatically recovered, and the items which have not been recovered or permanently deleted by the user, may be accessible via a trash mechanism. This is used in the file manager, for files, and in mail clients, for messages.
rodney is write if i take a look at the icons, yes. anyway, it's up to somebody to decide...
Hmm dobey, still, I some how feel DELETE sound more appropriate than REMOVE. To be frank, I hear lot of people use the term DELETE your a/c and recreate, when solving customer issues.
People also say Delete file xxx and re-install the application, all the time for problems on Windows as well. But it's a very different concept. I think Remove is the more appropriate term for the UI. If support needs to be better trained, then I think we should train support better, not fix the UI to match the language they currently use in support calls. The language used should match the UI. The UI shouldn't have to match common language used when supporting it. The button in the account prefs is "Remove" currently anyway, so support should be saying "Click the Remove Button" or something. However, since delete/remove are synonyms, it is also okay to use them synonymously in English when talking. I still think Remove is the best choice.
Well, FWIW, I still think 'Delete' is more appropriate, as your account details haven't just been 'Removed' to to somewhere else in the UI from whence you can trivially restore them. If you want to do that, you would just use the enable/disable account feature, I guess. Ultimately I think this is another one of those "Search" v "Find" discussions though-- there's a subtle difference to the few who care, but most people don't, and the subtlety is probably lost (either unwittingly or just due to lack of equivalents) in many localisations anyway. So frankly I wouldn't spend too much time debating it.
removing old target milestone.
i like comment 10, and i'm going to come up with a clean patch for evolution 2.9 which uses "delete". thanks a lot for the opinions and the input on this issue.
Bumping version to a stable release.
(In reply to comment #0) > When clicking the Remove button on the Mail Accounts preferences page, It is called "Delete" in 3.2 and all other issues expressed in comment 0 are fixed too (no dialog window title, correct order of buttons). Closing as FIXED.