After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 306118 - GAL string "dialog1" translatable
GAL string "dialog1" translatable
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Do Not Use
2.4.x (obsolete)
Other All
: Normal trivial
: ---
Assigned To: André Klapper
Evolution QA team
Depends on:
Blocks: 236276 327508 327510
 
 
Reported: 2005-06-01 07:38 UTC by Clytie Siddall
Modified: 2013-09-13 12:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch, fixes only the second issue. (1.90 KB, patch)
2005-06-14 14:26 UTC, André Klapper
none Details | Review

Description Clytie Siddall 2005-06-01 07:38:30 UTC
Version details: Gnome 2.12/HEAD

1.
po:44
reference:	⑤	gal/e-table/e-table-config-no-group.glade.h:20
reference:	⑤	gal/e-table/e-table-config.glade.h:21
Original:	⌘0	dialog1
(Do you really want this translated?)

2. The usual duplicate strings, bar a full stop or capital letter (only two: it's improving!).

po:88
reference:	⑤	gal/e-table/e-table.c:3313
Original:	⌘0	Always Search

.po:93
reference:	⑤	gal/e-table/e-tree.c:3300 gal/e-table/e-tree.c:3301
Original:	⌘0	Always search
___
po:114
reference:	⑤	gal/e-text/e-text.c:3545 gal/e-text/e-text.c:3546
Original:	⌘0	Fill stipple

po:247
Original:	⌘0	FIll stipple
Comment 1 André Klapper 2005-06-02 10:42:09 UTC
adding dependency
Comment 2 André Klapper 2005-06-09 14:28:56 UTC
i'm working on this
Comment 3 André Klapper 2005-06-14 14:26:17 UTC
Created attachment 47758 [details] [review]
patch, fixes only the second issue.
Comment 4 André Klapper 2005-06-14 17:30:12 UTC
patch submitted to e-p
Comment 5 André Klapper 2005-08-30 09:37:13 UTC
patch needs work due to retirement of independent GAL.
Comment 6 André Klapper 2005-11-21 23:33:49 UTC
moving
Comment 7 André Klapper 2005-11-25 00:31:30 UTC
reassigning since rodo does not work anymore on evo/gtkhtml
Comment 8 André Klapper 2005-12-23 02:58:25 UTC
current cvs, state of the art:

'Always search' exists in
/evolution/widgets/table/e-tree.c
/evolution/widgets/table/e-tree.c

'Always Search' existed in /evolution/widgets/table/e-table.c.
i just patched this to 'Always search', see
http://cvs.gnome.org/viewcvs/evolution/widgets/table/e-table.c?r1=1.239&r2=1.240

'FIll stipple' does not exist anymore.

translatable 'dialog1' still exists in files
  /evolution/widgets/table/e-table-config.glade:
    <widget class="GtkDialog" id="e-table-config">
    <property name="title" translatable="yes">dialog1</property>
  /evolution/widgets/table/e-table-config-no-group.glade:
    <widget class="GtkDialog" id="e-table-config">
    <property name="title" translatable="yes">dialog1</property>

so where in the UI can i see those dialogs?
if they are never visible, perhaps translatable="yes" should be changed to "no".

it's the same with "dialog1" in bug 306117. please also take a look at that one.
Comment 9 André Klapper 2005-12-23 03:13:02 UTC
the other three <widget class="GtkDialog"> in /evolution/widgets/table/e-table-config.glade
are for 'shown fields', 'group by' and 'sort' to set the view options within "define views > edit". but where should that fourth one go to?

all four GtkDialog widgets get called in /evolution/widgets/table/e-table-config.c, the "dialog1" one at line 1110 (rev 1.73):
config->dialog_toplevel = glade_xml_get_widget (
gui, "e-table-config");
if (config->header)
gtk_window_set_title (GTK_WINDOW (config->dialog_toplevel), config->header);
Comment 10 André Klapper 2006-01-27 14:32:58 UTC
#: ../plugins/groupwise-features/proxy-listing.glade.h:2
#: ../plugins/publish-calendar/publish-calendar.glade.h:28
#: ../smime/gui/smime-ui.glade.h:49
#: ../widgets/table/e-table-config-no-group.glade.h:20
#: ../widgets/table/e-table-config.glade.h:21

status of "dialog1" should become untranslated. this is possible according to 155294.
Comment 11 André Klapper 2006-01-27 15:13:20 UTC
i have committed a fix to cvs which removed string "dialog1" from translation.
closing as fixed.