GNOME Bugzilla – Bug 305874
Move Show combo box functionality to View menu
Last modified: 2011-11-11 10:03:55 UTC
How about moving the Show combo box functionality in the Processes tab to radio menu items in the View menu? This isn't such a common operation and it would free up space to view more processes (if load averages was moved to, I filed another bug about that).
See bug 305875 for "Put load averages in status bar".
Since putting load averages in the status bar probably is a bad idea (see bug 305875)... how about displaying which processes are viewed in the status bar if the selection is done in the view menu. When you do the selection in the combo box, this isn't needed since you already have that information in... the combo box ;)
Created attachment 47070 [details] [review] patch i don't think it would be usefull to display which processes are displayed. Here's a patch to remove the combo and add radio items in the View menu ... now the loadavg ~bar looks a bit empty. May be we could use this space to display uptime ? bootime ? idle_time ?
ping
Oh, you wanted a pong on this? Tried it out only a couple of hours after you added the patch and have basically been away since then. It looks great. I don't know about replacing the combo box with some other info. I basically think the loadavg ~bar is misplaced and you seem to think so too. Perhaps uptime etc can be added when bug 305875 is closed. But hey, you're the maintainer, not me. :)
Looking over the patch again it looks like the mapping from gconf to ui has changed from "All, My, Active" to "Active, All, My". All will be Active, My will be All and Active will be My. Having them in alphabetical order is all well and good, but this will muck about with the users preferences when they upgrade or in deployments where older versions of GNOME coexist with newer versions that have this patch applied. Will changing the order radio_menu_entries and not in ui_info fix this but still keep them in alphabetical order in the menu? If I've misread the patch (I'm to lazy to apply it again) please ignore this comment. :)
{ .name = "ShowActiveProcesses", .stock_id = NULL, .label = N_("Active processes"), .accelerator = NULL, .tooltip = N_("Show active processes"), .value = ACTIVE_PROCESSES }, typedef struct { const gchar *name; const gchar *stock_id; const gchar *label; const gchar *accelerator; const gchar *tooltip; gint value; } GtkRadioActionEntry; gint value; The value to set on the radio action. See gtk_radio_action_get_current_value().
D'OH! I knew I should have kept my yapper shut or investigated more thoroughly. :/