GNOME Bugzilla – Bug 304148
Export dialog reports PSD files do not support layer masks
Last modified: 2008-01-15 12:54:10 UTC
Distribution/Version: Debian Testing 1. Open a PSD file containing a layer mask. 2. Save the PSD file. What happens: GIMP reports that PSD files cannot handle layer masks. What should happen: GIMP should save the image, layer masks and all. PSD files definitely can handle layer masks.
Patches to the PSD plug-ins would be welcome...
GIMP doesn't report that PSD files do not support layer masks, it tells you that the PSD plug-in doesn't support them. *** This bug has been marked as a duplicate of 109841 ***
>GIMP doesn't report that PSD files do not support layer masks, it tells you that >the PSD plug-in doesn't support them. GIMP reports the former. See attached screenshot.
Created attachment 46434 [details] GIMP's error message
Resetting an obviously duplicated bug (did you even *read* it?) only serves to annoy developers. *** This bug has been marked as a duplicate of 109841 ***
The message in the export dialog is indeed confusing. This message is created in a generic fashion, so this is not trivial to fix. Reopening and setting severity to minor.
Quick idea: Rephrase the message to "The PSD-Plugin cannot handle...". This would be always correct, although it is usually not the plugin that is to blame...
The string is created in libgimp/gimpexport.c: _("%s can't handle layer masks"), format_name The PSD plug-in could pass "PSD plug-in" as the format name.
This solution is not quite right since "PSD plug-in" is not the format name. The API doesn't allow to differentiate between "the format doesn't support" and "the plug-in doesn't support".
What about just treating all "can't support" as "plug-in can't support"? That's as easy as replacing all _("%s can't handle foo") by _("%s plug-in can't handle foo")
Saving layer masks appears to be working in SVN HEAD. The error mentioned above is due to GIMP_EXPORT_CAN_HANDLE_LAYER_MASKS not being included in the set of options passed to gimp_export_image in run() of the psd_save.c file. This makes the export routine think the PSD file format doesn't support layer masks. This bug could be closed as the problem has been fixed in SVN HEAD or the fix can be backported to the 2.2 version of GIMP. It doesn't look like the changes needed are that extensive. If you want to backport the changes I can do that and attach a patch to this report.
2007-03-05 Sven Neumann <sven@gimp.org> * libgimp/gimpexport.c: changed strings as suggested in bug #304148). Kevin, please change the export capabilities in the trunk. I don't think we want to backport any new features to the 2.2 version at this point. We have made bad experiences with doing that in stable branches and we should concentrate on releasing 2.4.
Closing this report since the export capabilities of the trunk version handle layer masks and the suggested string change has been made.
><HTML><BODY><IMG width="512" src="http://bugzilla.gnome.org/attachment.cgi?id=46434" alt="http://bugzilla.gnome.org/attachment.cgi?id=46434" style="cursor: -moz-zoom-in;"/></BODY></HTML>