GNOME Bugzilla – Bug 303856
Appointment Editor's OK button still greyed out after changing value
Last modified: 2013-09-10 14:04:15 UTC
it is likely that this is a duplicate, but i really have searched a long time for this; and this bug exists since 1.5. open an existing appointment by double-clicking on it. change its beginning time (does not matter if you overwrite the value or if you use the up/down arrow keys). the "OK" button is still greyed out and disabled. therefore posting this here and today (calendar hackfest will begin in a few hours, so please fix this; and, dear bug fixer, if you are going to guadec 2005, you will perhaps get a free beer if we meet ;-)
hum, i also should target this to 2.3 (fix could also go into 2.2.3).
sorry, this obviously is calendar and not contacts (should go to bed within the next hours).
naaa, this is not fixed at all. i can reproduce this with 2.3.5.1 and 2.2.3. 1) set up an appointment and save it and close it. 2) reopen it by double-clicking on it. 3) click into the beginning date and change the date to sth in the past. "ok" button will be still greyed out, i have to click first somewhere else to enable "OK".
Anre, is it. Im not able to get it.. U type or use the date selected. On both cases im able to see OK getting fine.
hi srag, ok, i still see this running evolution-2.3.5.1.0.200507190649-0.snap.novell.11.1 on suse9.3 here. set up a new appointment, doesn't matter in which way. if i click into the date of the starting time (e.g. "29|.07.2005" where | is my cursor) and then mark the 9 by keyboard or mouse to replace it for example by an 8, the OK button is still greyed out. i realize that if i switch to another window by "alt + tab" and then go back to the appointment editor window, the OK button is not greyed out anymore. hmm. running metacity-2.10.0-5 here. so perhaps there's the problem.
bug 317815 is a bit similar; retargetting to 2.5
*** Bug 319144 has been marked as a duplicate of this bug. ***
Updating the bug as resolved as observed from the Changelog by Johnny Jacob
srini: it is solved in CVS HEAD indeed, is it also solved in 2.4? i cannot control it as nobody tells me the exact changelog entry or the file. *transparency*, dudes! ;-) reopening, sorry.
andre, thanks for reminding about 2.4.x. I just keep forgetting it. It is in the patches list. Ill get this too 2.4.x as well.
this is still buggy - the save button is still greyed out after i have changed the calendar of an appointment. running 2.5.2 from cvs head, checkout the day before yesterday.
ive tested johnny's patch. It worked for time/date which was the original bug about. This is a but that rised out of the new design of calendar UI. We are still working on a lot of things in this UI. Hope andre, you can understand the state of this code. Anyway lets keeps this, if you reset the sub or file a new bug, anything is fine for me. :-)
We need to test if Save is enabled by changing all possible values before closing this bug.
*** Bug 323704 has been marked as a duplicate of this bug. ***
Please fix it for tasks too.
*** Bug 322301 has been marked as a duplicate of this bug. ***
also see bug 329749
...and bug 330633
Ubuntu bug about that: https://launchpad.net/distros/ubuntu/+source/evolution/+bug/33961 "Evolution Calendar problems saving when changing appointments from one calendar to another Let's say you have more than one calendar in evolution and you make an appointment in one of them. If you later decide you want to move the appointment to another calendar, open it up switch calendars with the drop down list. You'll then notice the problem: the save button is still greyed out and does not become active (clickable). You can note however, that when you close the appointment evolution will alert you to the fact that the appointment is not yet saved, and will ask you if you want to save it. It's obvious that the save button should be activated when any change is made to the appointment."
Created attachment 67376 [details] [review] enabled the save button when the group is changed from a previously saved meeting this patch enables the save button when the group is saved from a previously saved button.... andre, i know that the beer u offered might be cold ... but so wat u can get a new un , right?? ;)
Changed the status to committed.
arvind: hehe... i can try to convince srini or parag to take it with them and hand it over to you when they get back from guadec or so ;-) patch has been only committed to HEAD, this must also be committed to gnome-2-14 branch. (grumble...)
retargetting to 2.6, please review!
can we just try to cover all the issues, please, by testing all the widgets that could be changed? there are quite some similar bugs around here, about the calendar list drop down (bug 346746), the timezone (bug 330633), and i guess other reports i don't know about. arvind?
*** Bug 346746 has been marked as a duplicate of this bug. ***
patch committed to stable branch also, will be included in 2.6.3: http://cvs.gnome.org/viewcvs/evolution/calendar/gui/dialogs/event-page.c?r1=1.110.2.5&r2=1.110.2.6 arvind: for future reference, please use "/* comment */" instead of "// comment". arvind, can you also take a look at the remaining widgets and if all signals are correctly emitted? thanks. :-)
for the CC'ed folks willing to compile: there is a patch attached at bug 330633 which should fix the timezone issue here. comments, in general, are always welcome.
Im closing this bugs, as arvind checked all the buttons in appointment editor. Fixed to HEAD and Stable.