GNOME Bugzilla – Bug 261084
"match-all" and "match-threads" in evolution camel needs translator comments
Last modified: 2007-08-27 09:22:54 UTC
#: camel/camel-folder-search.c:672 camel/camel-folder-search.c:705 msgid "(match-all) requires a single bool result" #: camel/camel-folder-search.c:755 msgid "(match-threads) not allowed inside match-all" #: camel/camel-folder-search.c:758 camel/camel-folder-search.c:762 msgid "(match-threads) requires a match type string" #: camel/camel-folder-search.c:784 msgid "(match-threads) expects an array result" #: camel/camel-folder-search.c:790 msgid "(match-threads) requires the folder set" These messages probably need translator comments (see http://developer.gnome.org/doc/tutorials/gnome-i18n/developer.html#use-comments) to explain what match-threads and match-all is and whether they should be translated or not.
Status?
the text inside ()'s is not for translation, it is the function name used in the filter scripting language
Then please replace the function name with an %s in these messages in a printf*-like approach, in order to make the messages generic. Having function names hard coded in messages marked for translation is bad for multiple reasons: 1) Only stuff that should actually be translated should be marked for translation. Stuff that shouldn't be translated but still is marked for translation only complicates things for translators. 2) Having stuff that shouldn't be translated hard coded into translateable messages is not good design, since if these function names change or other functions need to output similar messages all translations will need updating, whereas with a printf-based approach this would not be the case. 3) Having stuff that shouldn't be translated in messages marked for translation unnecessarily introdocuces another significant possibility for errors, in that translators may actually "translate" the function names, or put other typos in by accident. With "stuff that shouldn't be translated" is often meant all names that never change, such as function names, file names etc. http://developer.gnome.org/doc/tutorials/gnome-i18n/developer.html#generic In addition, please provide translator comments for these messages, so that translators will know that this is function names (or, if the printf*-style solution is used, that the %s gets replaced with a function name): http://developer.gnome.org/doc/tutorials/gnome-i18n/developer.html#use-comments
retargetting the string translation bugs that were targetted to 2.1 to 2.3. for an entire list see bug 236276.
camel was moved to eds; still correct in e-d-s-1.4
Created attachment 92631 [details] [review] fixed using g_strdup_printf
Jared, looks fine to commit. Please announce to the i18n list, while committing the patch.
Thanks - I thought it might be nice to get this old bug out of the way. String change has been announced. Unfortunately, I don't have commit access, somebody else will have to do that. :)
Committed revision 7937.
Thank you :)
hmm. a translator comment for "(%s) not allowed inside match-all" would be nice (to not translate "match all", but anyway. better now. :-)
Created attachment 93879 [details] [review] trivial fix Good point, I didn't notice that. Anyway here is a fix (using g_strdup_printf rather than a translator comment seems to me like the better solution here). :)
cimmtted to trunk rev 7994. Thanks.
Great, thanks :)