After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 255303 - changing folders strangeness
changing folders strangeness
Status: RESOLVED WONTFIX
Product: evolution
Classification: Applications
Component: Do Not Use
2.6.x (obsolete)
Other All
: Normal minor
: Future
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
: 227697 236532 257062 257584 260376 (view as bug list)
Depends on:
Blocks: 327508 327510
 
 
Reported: 2004-03-08 15:21 UTC by Michael Wolf
Modified: 2013-09-13 12:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
55303-mailer.patch (4.86 KB, patch)
2004-04-14 22:39 UTC, Jeffrey Stedfast
none Details | Review
55303-mailer-2.patch (6.47 KB, patch)
2004-05-04 21:01 UTC, Jeffrey Stedfast
committed Details | Review

Description Michael Wolf 2004-03-08 15:21:41 UTC
Please fill in this template when reporting a bug, unless you know what you
are doing.
Description of Problem:
When I switch from folder A to folder B back to folder A, I find myself
looking at a different part of folder A than I had been the first time.

Steps to reproduce the problem:
1. Go into folder A, scroll down to the bottom (where the new messages are)
2. Go to folder B
3. Go back to folder A

Actual Results:
The scrollbar is somewhere in the middle of folder A, not at the bottom
where I left it.

Expected Results:
I should still be at the bottom of A.

How often does this happen? 
"Sometimes".  If there's a pattern to it, I'm not sure what it is.

Additional Information:
Comment 1 Jeffrey Stedfast 2004-03-10 19:36:37 UTC
basically this comes down to:

we need to remember the scrollbar position in addition to the selected
uid since in maws case, no message was selected and so we couldn't
jump back to the bottom of the list.
Comment 2 Not Zed 2004-03-11 08:00:04 UTC
can we:
 - get the top of view uid when we go away
 - jump back to that view position later on?

i think remembering/restoring scrollbar positions directly will be a
very unreliable way to do this.
Comment 3 Jeffrey Stedfast 2004-03-11 20:37:19 UTC
NotZed:

the problem with the UID thing is that ETable likes to adjust the
scroll position by "centering" the selected row.

the problem I see with the scrollbar position is that the number of
items in the message-list may change and thus we may need a different
scroll offset...

ugh. I dunno.
Comment 4 Not Zed 2004-04-02 09:33:04 UTC
whats wrong with centering on the selected message?  its better than
not showing it.
Comment 5 Not Zed 2004-04-08 08:28:06 UTC
btw i've been seeing other stuff to do with changing folders.

e.g. change to a big folder on a remote server, and then change to
another quickly.

you'll end up looking at the big folder but the other folder will be
shown as the selected folder in the tree.

Comment 6 Not Zed 2004-04-14 10:46:08 UTC
on the last point, that was my fault, trying to optimise interactivity
too much, folders could be set out of order.
Comment 7 Jeffrey Stedfast 2004-04-14 22:32:01 UTC
well, I've "fixed" this in the mailer code, except that the fix
doesn't work due to etable's scroll-to-cursor feature which apparently
is done in some idle callback or something.
Comment 8 Jeffrey Stedfast 2004-04-14 22:39:25 UTC
Created attachment 43580 [details] [review]
55303-mailer.patch
Comment 9 Jeffrey Stedfast 2004-04-14 22:40:02 UTC
the mailer portion of the patch will likely need to change to fit
whatever workaround gets created in etree, but whatever.
Comment 10 Jeffrey Stedfast 2004-04-15 15:16:16 UTC
*** bug 257062 has been marked as a duplicate of this bug. ***
Comment 11 Not Zed 2004-05-04 09:45:15 UTC
please look at this jeff.  mike certainly isn't going to.
Comment 12 Jeffrey Stedfast 2004-05-04 19:34:22 UTC
I already looked at it before, but couldn't figure out how scrolling
worked in etree for the selection stuff.

just got clahey to point me at e-table-item.c:eti_show_cursor() which
can sometimes be called in an idle handler.

followed that to e_canvas_item_show_area_delayed() in e-canvas-utils.c
which does canvasy stuff in a timeout.

now I'm just scared. I really don't know what the fuck I'm doing with
this code. I think I'm more likely to fuck shit up than actually
manage to fix this...

also note that there's a race condition in this code because sometimes
when I select a folder, the last selected message gets selected, but
etree never scrolls.

I'm really not the right person to mess with this code.
Comment 13 Jeffrey Stedfast 2004-05-04 21:01:23 UTC
Created attachment 43669 [details] [review]
55303-mailer-2.patch
Comment 14 Jeffrey Stedfast 2004-05-04 21:02:36 UTC
above patch works around this problem without having to modify ETable
stuff... going with this solution for now. Zucchi will probably revert
it tho. Oh well. I'll let him deal with fixing ETable if he wants a
better solution.
Comment 15 Not Zed 2004-05-05 05:26:45 UTC
I really don't like this patch.  But sure i guess it should go in.  I
actually don't like the whole way the scrollbar position is saved and
restored anyway.  It should save the top message, not the double
scrollbar location, but whatever.

ETable should really be fixed.

Anyway, i'm going to re-open this bug at a lower priority, since no,
it isn't fixed, although the symtpom in the mailer might be fixed by
the patch.
Comment 16 Not Zed 2004-05-05 07:34:18 UTC
*** bug 257584 has been marked as a duplicate of this bug. ***
Comment 17 Radek Doulik 2004-06-11 16:29:23 UTC
Michael, Jeff, what is the result. Is the patch applied? What do you
think about rescheduling that for 2.1 if the patch is applied?
Comment 18 Radek Doulik 2004-06-14 09:43:50 UTC
ops, I forgot to Cc you guys.
Comment 19 Radek Doulik 2004-06-14 09:44:24 UTC
Michael, Jeff, what is the result. Is the patch applied? What do you
think about rescheduling that for 2.1 if the patch is applied?
Comment 20 Jeffrey Stedfast 2004-06-14 13:18:10 UTC
the patch is already applied, but it'd be nice if we can fix this. I'd
say it's not a high priority tho...
Comment 21 Mattias Eriksson 2004-06-14 14:38:00 UTC
Using 1.5.9.1 from debian unstable I still see this problem sometime
for my IMAP mailboxes (I only have IMAP mailboxes, so I don't know if
it is still there for other mailboxes). 
It doesn't happen every time, but sometimes it sets the possition to
some other place in the mailbox. It seems to be the same wrong
possition  in the mailbox too, at least as long an nothing else has
changed (no new mail aso). 
Comment 22 Jeffrey Stedfast 2004-06-17 23:34:19 UTC
*** bug 260376 has been marked as a duplicate of this bug. ***
Comment 23 André Klapper 2005-03-05 15:53:31 UTC
adding patch keyword
Comment 24 Srinivasa Ragavan 2005-12-14 04:16:22 UTC
andre, the patch in the list is already applied. And i tried reproducing it. I
couldnt. It works for me. As Mattias said, may be occuring in some specific
scenario.
Comment 25 André Klapper 2006-01-06 11:46:25 UTC
retargetting, moving to evolution.
Comment 26 André Klapper 2006-01-06 12:13:34 UTC
also see bug 325922
Comment 27 André Klapper 2006-01-23 21:22:52 UTC
*** Bug 227697 has been marked as a duplicate of this bug. ***
Comment 28 André Klapper 2006-03-05 01:22:14 UTC
changing target milestone from 2.5 to future. sorry, too many bugs, too less time.
Comment 29 André Klapper 2006-03-30 01:18:09 UTC
*** Bug 236532 has been marked as a duplicate of this bug. ***
Comment 30 Matthew Barnes 2008-03-11 00:27:12 UTC
Bumping version to a stable release.
Comment 31 André Klapper 2011-10-05 13:34:26 UTC
Does this still happen in 3.2/3.0.3?
Comment 32 Milan Crha 2012-04-23 12:09:12 UTC
It does happen, and I say WontFix. Select the message and this is remembered, no way to play with scrollbar position, it'll just make things unnecessarily complicated (think also of different themes with different font sizes and so on).