After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 245025 - Popup confirmation when moving a folder (via drag and drop)
Popup confirmation when moving a folder (via drag and drop)
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
3.2.x (obsolete)
Other other
: Normal enhancement
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
: 353445 661414 666468 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-06-17 22:53 UTC by Edward Rudd
Modified: 2012-04-06 19:58 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
evo patch (7.69 KB, patch)
2012-04-06 16:31 UTC, Milan Crha
committed Details | Review

Description Edward Rudd 2003-06-17 22:53:51 UTC
I would like an option added so that Evolution can ask the user if they
really want to move a mail folder into another mail folder..  This is due
to an annoyance where if you select a mail folder and "slightly" move the
mouse while the button is down evolution will move the selected folder into
the folder just above or just below..
Comment 1 André Klapper 2012-02-07 22:14:47 UTC
*** Bug 353445 has been marked as a duplicate of this bug. ***
Comment 2 André Klapper 2012-02-07 22:14:50 UTC
*** Bug 661414 has been marked as a duplicate of this bug. ***
Comment 3 Luciana Fujii 2012-03-19 20:33:16 UTC
Let me be a little pushy here and say that could be considered a bug instead of just and enhancement. It's really easy to move folders unintentionally, and I apparently hit another bug which resulted in the folders I moved unintentionally to be deleted. But even without that, it's a lot of trouble moving hundreds of mail around imap without confirmation, when the draggable directories are right beside the scrollbar.
Comment 4 Matthias Clasen 2012-03-20 01:26:28 UTC
I agree. It happens to me all the time. Dnd in the folder tree is basically *always* unintentional and harmful, we would be much better off without it.
Comment 5 Milan Crha 2012-04-06 13:53:06 UTC
*** Bug 666468 has been marked as a duplicate of this bug. ***
Comment 6 Milan Crha 2012-04-06 16:31:03 UTC
Created attachment 211489 [details] [review]
evo patch

for evolution;

This does the confirmation dialog with options Yes/No/Always/Never. I also distinguish between copy and move operation, and once you have for it "never", then the drop just does nothing. This command can be used to let it ask for move operation again (key is similar for 'copy'):
   $ dconf write /org/gnome/evolution/mail/prompt-on-folder-drop-move "\"\""

Note of the removal of tree_drag_data_delete(), because it was redundant there, and could lead to misbehaviour (in this function was called camel_store_delete_folder_sync(), while the same is done in em_folder_utils_copy_folders()). The GTK_DEST_DEFAULT_DROP does a little bit mess here as well, as it was calling gtk_drag_finish() again (evo's code called it already as unsuccessful), as succeeded and in case of move operation as to-delete, thus this camel_store_delete_folder_sync() was called within tree_drag_data_delete() on a folder which was supposed to stay as is.
Comment 7 Milan Crha 2012-04-06 16:36:32 UTC
Created commit 37e79de in evo master (3.5.1+)

Removal of tree_drag_data_delete() from stable (only that function remove):
Created commit b35a84a in evo gnome-3-4 (3.4.1+)
Comment 8 Johannes Schmid 2012-04-06 19:58:23 UTC
Thanks a lot!