After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 243201 - vfolder name problems with "&"
vfolder name problems with "&"
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Shell
2.2.x (obsolete)
Other All
: Normal minor
: Future
Assigned To: Milan Crha
Evolution QA team
evolution[vfolders]
: 320582 500039 (view as bug list)
Depends on:
Blocks: 248861
 
 
Reported: 2003-05-17 03:26 UTC by trow
Modified: 2008-07-03 09:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed evo patch (1.02 KB, patch)
2008-07-02 16:01 UTC, Milan Crha
committed Details | Review

Description trow 2003-05-17 03:26:22 UTC
Adding a vfolder named "Foo/Bar" leads to weirdness:

(1) As long as the vfolder editor is up, it appears in the shell as a
folder "Foo" containing an item called "Bar".

(2) When you close the vfolder editor, it changes to a folder named "Foo"
w/o subfolders.  When you select it, the screen says that the folder can't
contain messages.  It also doesn't go away if you try to delete it.

(3) If you exit evo and restart, the mysterious "Foo" folder disappears.
Comment 1 Gerardo Marin 2003-05-17 21:37:23 UTC
Old, old request.
However, al prior reports are closed. So... levae this open.
1.4.x. Only if there's time, 1.4
Comment 2 trow 2003-05-17 23:05:03 UTC
In a related bug, a vfolder named 'Foo & Bar' gets truncated to 'Foo '
after exiting and re-starting evo.  But you probably already knew that.
Comment 3 André Klapper 2005-01-23 01:31:28 UTC
evolution-2.1.3.2.0.200501160930-0.snap.ximian.10.1:

"/":
a folder named "foo" and a subfolder named "bar" will be set up; the 
vfolder with its rules is of course "bar", both are fully accessible 
and the vfolder rule is working.
so it seems like "/" is not escaped.

"&":
as described by troy in his last comment, it gets truncated. :-(

"#":
no problems, closing bug 236477 dealing with this.
Comment 4 André Klapper 2005-01-26 21:09:24 UTC
"/" is a duplicate of bug 271105 which should be fixed in 2.1.4 
according to changelog.
Comment 5 Not Zed 2005-01-31 08:49:10 UTC
/ IS legal in the vfolder editor, it can be used to define subfolders,
but not to name individual folder paths.

Hmm, & seems to be a problem with the stupid libxml api not escaping
things we give to it.

i.e. this:

	if (fr->name) {
		work = xmlNewNode (NULL, "title");
		xmlNodeSetContent (work, fr->name);
		xmlAddChild (node, work);
	}

is apparently wrong, even though GetContent de-escapes everything.
Comment 6 André Klapper 2005-02-14 11:40:49 UTC
adding vfolders keyword.
Comment 7 André Klapper 2005-11-03 22:32:43 UTC
also see bug 320582
Comment 8 André Klapper 2006-01-09 02:18:34 UTC
futuring, sorry
Comment 9 Karsten Bräckelmann 2006-01-23 18:57:03 UTC
*** Bug 320582 has been marked as a duplicate of this bug. ***
Comment 10 Karsten Bräckelmann 2006-01-23 19:01:03 UTC
IMHO the ability to create a hierarchy and nested vFolders easily by using a "/" char is an important *feature*, not a bug. I do use it regularly, it keeps my vFolders structured and makes spotting the vFolder I want easy.
Comment 11 Karsten Bräckelmann 2006-01-23 19:05:11 UTC
Note: With current Evo versions there is absolutely no weirdness whatsoever as described in the original report regarding "/".

This just works perfectly and entirely smoothless. It just creates a folder structure. All sub- and parent-folders are fully functional vFolders as well.
Comment 12 Matthew Barnes 2008-03-11 00:21:44 UTC
Bumping version to a stable release.
Comment 13 Milan Crha 2008-04-02 09:52:34 UTC
*** Bug 500039 has been marked as a duplicate of this bug. ***
Comment 14 Milan Crha 2008-07-02 16:01:14 UTC
Created attachment 113865 [details] [review]
proposed evo patch

for evolution;

As suggested by Not Zed, just escaping the title works fine. But I've such a feeling we will need to escape all text values in saving, just to be sure it will work properly. (I didn't change the behaviour for the slash, because I agree with guenther, it's fine to create subfolders based on the name.)
Comment 15 Milan Crha 2008-07-02 16:03:49 UTC
Changing summary from "vfolder name problems with "/" and "&"" to "vfolder name problems with "&"".
Comment 16 Srinivasa Ragavan 2008-07-03 06:59:01 UTC
Milan looks fine to me. Commit 
Comment 17 Milan Crha 2008-07-03 09:29:31 UTC
Committed to trunk. Committed revision 35716.