After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 216073 - Editing contacts from To: menu doesn't make inline changes
Editing contacts from To: menu doesn't make inline changes
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Contacts
2.2.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks: 327508 327510
 
 
Reported: 2001-11-27 00:41 UTC by Joe Drew
Modified: 2013-09-13 00:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (2.17 KB, patch)
2006-03-03 09:11 UTC, Devashish Sharma
none Details | Review

Description Joe Drew 2001-11-27 00:41:30 UTC
Create a new message and address it to a contact. Right-click on that
contact and edit it. Change the contact's e-mail address. Save and close
the edit contact dialogue. Now right-click on the contact in the address
box: note that it still displays the old e-mail address. Sending this
message sends it with the old e-mail address, too (can check this easily if
you have multiple e-mail addresses).
Comment 1 trow 2001-11-27 07:23:18 UTC
Unfortunately, this is not really easy to fix.
Comment 2 André Klapper 2004-07-16 00:24:42 UTC
i'd really like to test this against evolution1.5-1.5.90.0.
200407090432-0.snap.ximian.8.1, but when i right-click on the 
recipient's name in the TO:-field of the composer window, i would 
assume that the first entry of the popup menu (where the text of this 
entry is the name of the contact with a little contact card icon at 
the left) should do something when i click on it, but nothing happens. 
so i cannot test this. raising priority from minor to normal.
Comment 3 André Klapper 2005-02-07 17:00:11 UTC
editing the contact by right-clicking on it works again in evolution-
2.1.4.0.200502040900-0.snap.ximian.10.1 (see bug 245454), and is still 
buggy:

i set up a new email composer window.
i enter a recipient into the to field.
i let it autocomplete, right-click on the name and choose the first 
item which opens a writable contact editor (making more clear that 
this is a contact editor indeed is bug 260851).
i add a value (e.g. an icq number or a telephone number) which was 
blank before, and hit enter to close the contact editor.
if i go to the addressbook, it's definitely saved, i can see the value 
there when i open the contact editor from the addressbook.
but if i right-click on the name again and reopen the contact editor, 
the field i just entered a value to is blank, so this is not 
synchronized with the backend. if i then hit "OK" (it's greyed out, 
but one can easily activate it by changing any dropdown menu value) 
the value is deleted again because my contact information gets saved 
again.
and changing the email address still does not update the recipient's 
email address in the email, though the contact's email address *has* 
changed as one can see when opening the addressbook.
Comment 4 André Klapper 2005-02-09 17:41:43 UTC
related to bug 220108
Comment 5 Devashish Sharma 2006-03-03 09:11:35 UTC
Created attachment 60542 [details] [review]
Patch
Comment 6 André Klapper 2006-03-03 14:12:09 UTC
...i guess it would break abi/api freeze because of the function signature change? if so, please set target milestone to 2.7 and remove the two dependencies. thanks very much in advance.
Comment 7 Sushma Rai 2006-03-04 04:45:42 UTC
the callback is not an API. So will not break the the freeze.
But the signature of the callback need not be changed here.

Devashish, you can still pass the ENameSelectorEntry as gpointer and use it.
rest of the comments are in my reply to the patch in the mailing list.
Comment 8 Devashish Sharma 2006-03-05 10:18:48 UTC
Fix committed to cvs head, with the suggested changes.