GNOME Bugzilla – Bug 200215
Disable functions based on selection in the message list
Last modified: 2005-11-15 02:22:21 UTC
* Disable Reply, Reply-to-All, Forward, Delete, and Print when no messages are selected or available. * When multiple messages are selected: A) Disable Reply and Reply-to-All when multiple messages are selected. B) Print should queue all the messages for printing C) Forward should attach all selected messages D) Delete should mark selected messages as deleted
- added placeholder for signal selection_changed signal, waiting for http://bugzilla.ximian.com/show_bug.cgi?id=196 - disable reply, reply-to-all in popupmenu works - forward all seemed to be allready working... - same for delete all - print all is beyond my (current) capabilities :-(
Created attachment 39876 [details] [review] patch created with cvs diff
done with most of it. I'm wondering whether some more items in the message menu should be disabled, if no message is selected, since they don't seem to work anyway then... !!print should queue all is not done!! I feel for this I would need to change too much, I'd like that done by someone with more insight in the code... maybe this should go in a new bug??? I'll just set resolution to fixed for now...
This code never acatually got committed. And it's probably way out of date now, so it will need to be updated.
*** bug 202095 has been marked as a duplicate of this bug. ***
*** bug 202758 has been marked as a duplicate of this bug. ***
*** bug 203309 has been marked as a duplicate of this bug. ***
I apologize for the spam; re-setting all target milestones to 'future' in preparation for evolution 1.0. If you have any questions, please feel free to write louie@ximian.com.
*** bug 205085 has been marked as a duplicate of this bug. ***
(5085 has a possibly comprehensive list of relevant menu commands)
*** bug 205086 has been marked as a duplicate of this bug. ***
*** bug 205088 has been marked as a duplicate of this bug. ***
(these others also have good info)
Adjusting the triage; if this is going to be fixed, it needs to be fixed before the UI freeze.
The patch attached way at the top of this bug is mostly good, but unfortunately the code now uses e_tree. which doesn't implement get_selection_count. Fortunately this has already been filed as bug 205353 so I'll make this depend on that.
I'll work on updating the patch.
Ok, this is fairly close to completion, but I don't want to commit until 6795 is fixed.
Created attachment 40137 [details] [review] Candidate patch
The attached patch works well for me, but again, I don't want to commit until 6795 is fixed.
*** bug 207180 has been marked as a duplicate of this bug. ***
Checked in, finally.
The File -> Print menu item, File -> Print Preview menu item, and Print toolbar button remain enabled even when no message is selected. But if there's nothing to print, they should be disabled. Consistently repeatable as follows: 1. Open a view of any mail folder. 2. If a message is selected, use <Control>-<Mouse 1> to deselect it. 3. Observe that while numerous other items have been (correctly) disabled, the printing controls remain available. One might argue that the current behavior is reasonable if we take printing to apply to the message currently being displayed in the preview pane. However, if the preview pane is closed, then how can the user possibly know which message would be printed? At the very least, these controls should be disabled when there is no selected message and the preview pane is closed. Note that bug 210346 seems at least somewhat related, though not quite a duplicate. Anyone attempting to fix this bug should at least be aware of bug 210346 as well.
fixed as far as I can tell