After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 171302 - messages of gnome-desktop-item-edit are not translated.
messages of gnome-desktop-item-edit are not translated.
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
2.10.x
Other All
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
: 171230 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-03-23 01:00 UTC by Young-Ho Cha
Modified: 2005-05-10 06:31 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
add bindtextdomain in libgnome-desktop/gnome-ditem-edit.c (592 bytes, patch)
2005-03-24 02:17 UTC, Young-Ho Cha 		committed Details | Review
remove textdomain() in gnome-ditem-edit.c (696 bytes, patch)
2005-05-10 02:11 UTC, Young-Ho Cha 		none Details | Review

Description Young-Ho Cha 2005-03-23 01:00:03 UTC 
Please describe the problem:
when running gnome-desktop-item-edit, messages are not translated.



Steps to reproduce:
1. run gnome-desktop-item-edit
2. 
3. 


Actual results:
running apps with localized messages

Expected results:
apps with english messages

Does this happen every time?
yes

Other information:
it seems can't load gnome-desktop-2.0.mo that contains translations of
libgnome-desktop/gnome-ditem-edit.c

(when running with strace, trying open
prefix/share/locale/????/LC_MESSAGES/messages.mo instead of gnome-desktop-2.0.mo)
Comment 1 Vincent Untz 2005-03-23 19:40:57 UTC 
gnome-desktop-item-edit is part of gnome-panel. So it should look for
gnome-panel-2.0.mo.

Are you using a distribution or a home-compiled GNOME? Is gnome-panel translated?
Comment 2 Vincent Untz 2005-03-23 19:50:11 UTC 
*** Bug 171230 has been marked as a duplicate of this bug. ***
Comment 3 Young-Ho Cha 2005-03-24 02:15:54 UTC 
yes. execution code is in gnome-panel, but ui code is in gnome-desktop. and ui
translations are in gnome-desktop, too.

i said, messages are in libgnome-desktop/gnome-ditem-edit.c. 

but there is no usage of bindtextdomain() and it seems producing this bug.
Comment 4 Young-Ho Cha 2005-03-24 02:17:19 UTC 
Created attachment 39173 [details] [review]
add bindtextdomain in libgnome-desktop/gnome-ditem-edit.c
Comment 5 Vincent Untz 2005-03-26 13:31:16 UTC 
Ah, you're probably right.

Mark: what do you think of the patch?
Comment 6 Mark McLoughlin 2005-04-13 07:39:59 UTC 
Thanks

2005-04-13  Mark McLoughlin  <mark@skynet.ie>

        Patch from Young-Ho Cha <ganadist@chollian.net> in bug #171302

        * gnome-ditem-edit.c: (gnome_ditem_edit_class_init):
        initialize i18n
Comment 7 Young-Ho Cha 2005-05-10 02:10:17 UTC 
there is no need to call textdomain(). it produces new bug(after open
gnome-desktop-item-edit, gnome-panel messages are untranslated.)

please apply this patch.
Comment 8 Young-Ho Cha 2005-05-10 02:11:51 UTC 
Created attachment 46265 [details] [review]
remove textdomain() in gnome-ditem-edit.c
Comment 9 Mark McLoughlin 2005-05-10 06:31:43 UTC 
See bug #302454 - fcrozat already has a patch to remove it. Thanks