After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 166732 - Fix up calling meta_display_set_input_focus_window with CurrentTime
Fix up calling meta_display_set_input_focus_window with CurrentTime
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
trunk
Other Linux
: High normal
: 2.10.x
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks: 155450
 
 
Reported: 2005-02-08 23:43 UTC by Elijah Newren
Modified: 2005-02-09 03:19 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
avoid using CurrentTime when focusing, handle it better in case we miss any cases (2.13 KB, patch)
2005-02-08 23:45 UTC, Elijah Newren 		accepted-commit_now Details | Review

Description Elijah Newren 2005-02-08 23:43:43 UTC 
Since Crispin filed bug 166728, I decide to look for other problems.  I found
one for shading, one for unshading, and the fact that
meta_display_set_input_focus_window and meta_display_focus_the_no_focus_window
don't handle CurrentTime gracefully (the will set display->last_focus_time to 0
when called like that; that's especially bad if the XServer has been up for more
than 25 days or so...).

I'll attach a patch in a minute.
Comment 1 Elijah Newren 2005-02-08 23:45:19 UTC 
Created attachment 37218 [details] [review]
avoid using CurrentTime when focusing, handle it better in case we miss any cases
Comment 2 Elijah Newren 2005-02-08 23:46:53 UTC 

*** This bug has been marked as a duplicate of 155450 ***
Comment 3 Elijah Newren 2005-02-08 23:47:40 UTC 
Ooops.  wrong field.
Comment 4 Elijah Newren 2005-02-09 03:19:07 UTC 
committed.