After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 165016 - Locations Love - Brazil
Locations Love - Brazil
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: gweather
git master
Other All
: Normal normal
: 2.10
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks: locations-love
 
 
Reported: 2005-01-23 20:40 UTC by Raphael Higino
Modified: 2005-02-01 23:32 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
Here's the patch (12.98 KB, patch)
2005-01-23 20:43 UTC, Raphael Higino
needs-work Details | Review
New patch for Brazil (14.04 KB, patch)
2005-01-30 14:03 UTC, Raphael Higino
needs-work Details | Review
Final patch RC1 (16.56 KB, patch)
2005-01-31 01:17 UTC, Raphael Higino
accepted-commit_now Details | Review

Description Raphael Higino 2005-01-23 20:40:24 UTC
Here are corrected locations names for Brazil.
I've also added some translators comments to ease translation work and corrected
some airport names which were spelled in Portuguese (now they are in English).
Comment 1 Raphael Higino 2005-01-23 20:43:17 UTC
Created attachment 36423 [details] [review]
Here's the patch
Comment 2 Danielle Madeley 2005-01-24 05:22:43 UTC
Comment on attachment 36423 [details] [review]
Here's the patch

Some comments on the patch.

>+      <!-- Translators: Original name is 'Anápolis' -->
>       <_name>Anapolis Braz-Afb</_name>

Why not simply change the name to Anápolis? What does Braz-Afb mean anyway?

>+      <!-- Translators: Original name is 'Bagé' -->
>       <_name>Bage</_name>

Same here.

>-      <_name>Belo Horizonte Aeroporto</_name>
>+      <_name>Belo Horizonte Airport</_name>

Is it useful to mention the airport? Could it just be written as Belo
Horizonte?

>-      <_name>Boa Vista Aeropor-To</_name>
>+      <_name>Boa Vista Airport</_name>

Same here.

>+      <!-- Translators: Original name is 'Carajás/Marabá'. It's an airport in Marabá, which is a city -->
>       <_name>Carajas/Maraba</_name>

Are there multiple locations in Marabá? Perhaps it would be more suitable to
use a <city> tag. If there aren't multiple locations then perhaps simply the
name Marabá would suffice?

>-      <_name>Leite Lopes/Ribeir</_name>
>+      <!-- Translators: Original name is 'Leite Lopes/Ribeirão Preto'. It's an airport in Ribeirão Preto, which is a city -->
>+      <_name>Leite Lopes/Ribeirao Preto</_name>

Same here.

>+      <!-- Translators: It's an airport in São Paulo -->
>       <_name>Marte Civ/Mil</_name>

What does Cil/Mil mean?
Comment 3 Raphael Higino 2005-01-24 13:03:56 UTC
> >+      <!-- Translators: Original name is 'Anápolis' -->
> >       <_name>Anapolis Braz-Afb</_name>
> 
> Why not simply change the name to Anápolis? What does Braz-Afb mean anyway?
> 
> >+      <!-- Translators: Original name is 'Bagé' -->
> >       <_name>Bage</_name>
> 
> Same here.

'Braz-Afb' means it's a Brazilian Air Force Base. IMO it's necessary as that is
 perhaps the most important AFB in Brazil and there's another airport in Anápolis.

About city names, Anápolis and Bagé have acute accent in them. I'd like they
were spelled in original ways but I guess the names should be anglicized,
shouldn't them? If it's allowed chars which have acute/circumflex accents,
tilde, etc., as I saw in msgid's of the resulting PO, I'll post another patch
using original names. In the case they are not allowed, I put those comments so
translator of language that support such chars will use them.

> >-      <_name>Belo Horizonte Aeroporto</_name>
> >+      <_name>Belo Horizonte Airport</_name>
> 
> Is it useful to mention the airport? Could it just be written as Belo
> Horizonte?

I know there are three airports in Belo Horizonte: Carlos Prates, Pampulha e
Tancredo Neves. In fact, Tancredo Neves international airport is in a city next
to Belo Horizonte called Lagoa Santa. I don't know about other airports in Belo
Horizonte.

The coordinates in Locations.xml.in seem to point to Pampulha airport. As Belo
Horizonte is the third biggest city in Brazil I think it's useful to mention
this airport besides the city itself.

> >-      <_name>Boa Vista Aeropor-To</_name>
> >+      <_name>Boa Vista Airport</_name>
> 
> Same here.

IMO it's useless mention the airport. It may be just "Boa Vista"

> >+      <!-- Translators: Original name is 'Carajás/Marabá'. It's an airport 
> in Marabá, which is a city -->
> >       <_name>Carajas/Maraba</_name>
> 
> Are there multiple locations in Marabá? Perhaps it would be more suitable to
> use a <city> tag. If there aren't multiple locations then perhaps simply the
> name Marabá would suffice?

As I could see Carajás airport isn't in Marabá but in Parauapebas. So we have
two different locations Carajás airport in Parauapebas and Marabá airport. I
don't think it's necessary to say they are airports as there aren't any other
airports in that cities. So Parauapebas and Marabá would be enough.

But we still have another problem: what airport is this entry pointing to? As I
could see coordinates in Locations.xml.in point Carajás airport, which is in
Parauapebas.

> >-      <_name>Leite Lopes/Ribeir</_name>
> >+      <!-- Translators: Original name is 'Leite Lopes/Ribeirão Preto'. It's
> an airport in Ribeirão Preto, which is a city -->
> >+      <_name>Leite Lopes/Ribeirao Preto</_name>
> 
> Same here.

AFAIK there's no other airport in Ribeirão Preto, so it's sufficient to say just
Ribeirão Preto (or Ribeirao Preto if tildes are not allowed).

> >+      <!-- Translators: It's an airport in São Paulo -->
> >       <_name>Marte Civ/Mil</_name>
> 
> What does Civ/Mil mean?

'Civ/Mil' means it's a Civilian/Military airport.
Comment 4 Danielle Madeley 2005-01-24 13:37:32 UTC
I am filled with irritation for bugzilla and it's lack of unicode support...
perhaps I can convince it this time to not butcher my characters.

Ok here are some guidelines that I have been working with:
 - mentioning that something is an airport is redundant unless there are
   multiple locations in that city, so you need to somehow differentiate
   between them.

   eg. YPPH is Perth Airport, but since it's the only location in Perth, we
       simply call it Perth
       London has multiple locations, Heathrow Airport, City Airport, etc.
       This is best represented as:
           London
             |- Heathrow Airport
             |- City Airport
             ...

   In the case of Anapolis Braz-Afb, if there are multiple locations for
   Anapolis, then it should be:
      Anapolis
        |- Airforce Base
        |- International Airport
   or something to that effect. The word Brazilian is redundant, we have already
   selected that we want Brazil.

 - Group and name things in a way that will make them easy for people to find.
   For example, the airport closest to me is in a city named Belmont, however
   this city is considered part of Greater Perth. So we just call the location
   Perth.

 - The entire unicode character set is available for names. When we say
   anglisised names, I mean things like the English name for München is Munich.
   If there is no common name like that, use the local name.

Hope this clears things up a bit.
Comment 5 Raphael Higino 2005-01-29 20:39:10 UTC
Sorry for being so dumb. Let me terminate some doubts.

Do you need me to post another patch?

In the case of Anápolis, which has two airports but the other one isn't in
Locations.xml.in, what should be done? Leave it just "Anapolis"? Include the
other one? Or do not include it make it "Anapolis AFB"

About the charset, in the case of "Barra do Garças", for instance, I'm sure
there's no common name for it in English. As I can use the entire unicode, can I
spell it with the 'ç' (cedill)?

I hope I have explained myself well.
Comment 6 Danielle Madeley 2005-01-30 04:39:43 UTC
A new patch would be fantastic!

If we don't have a METAR code for the missing airport, I guess we can't include it.

If we can't include it, change Anapolis AFB to Anapolis (use the accents, I just
can't type them on my keyboard)
If we can include it, make a city called Anapolis and have two locations:
Airport and Air Force Base.

You can use the cedill. Remember that most of the people looking for this
location will be used to seeing the cedill.

Thanks for being so patient, looking forward to that patch.
Comment 7 Raphael Higino 2005-01-30 14:03:53 UTC
Created attachment 36722 [details] [review]
New patch for Brazil

I've made a new patch following your guidelines. I also revised the name of the
cities.
Comment 8 Danielle Madeley 2005-01-30 14:25:27 UTC
Comment on attachment 36722 [details] [review]
New patch for Brazil

Ok, this is looking better. Just a few more issues. You still have some
mentions of the word airport, and we could really use some <city> tags.

>+      <_name>Belo Horizonte/Confins Airport</_name>

A new mention of airport

>-      <_name>Carajas/Maraba</_name>
>+      <_name>Carajás/Parauapebas</_name>

Is Carajas/Parauapebas two places that are near by?

>-      <_name>Curitiba Aeroporto</_name>
>+      <_name>Curitiba Airport</_name>

Another airport

>-      <_name>Leite Lopes/Ribeir</_name>

Are Leite Lopes and Ribeir two places near by?

>+      <_name>Manaus/Eduardo Gomes International Airport</_name>

Perhaps Manaus and Eduardo Gomes should be in a city tag.
eg.
 <city>
  <_name>Manaus</_name>
  <location>
   <_name>Eduardo Gomes...</_name>
   ...
  </location>
  <location>
   <_name>The name of the other location in Manaus</_name>
   ...
  </location>
 </city>

>+      <!-- Translators: It's an airport in São Paulo -->
>       <_name>Marte Civ/Mil</_name>

Do we need the Civ/Mil part? Also, perhaps it should be moved into a <city> tag
with Congonhas.

>-      <_name>Porto Alegre Aero-Porto</_name>
>+      <_name>Porto Alegre Airport</_name>

Another mention of the word Airport

>+      <_name>Rio de Janeiro</_name>
>+      <_name>Rio de Janeiro/Galeão Airport</_name>
>+      <_name>Rio de Janeiro/Jacarepaguá Airport</_name>

Rio de Janeiro would also benefit from a <city> tag.

Keep up the good work.
Comment 9 Raphael Higino 2005-01-30 16:11:56 UTC
> Ok, this is looking better. Just a few more issues. You still have some
> mentions of the word airport, and we could really use some <city> tags.

I know. I tryed to avoid using that word.

I swear I tryed to use <city> tag, but when I looked at London city and saw
<zone> tag I just didn't know what I was supposed to write there. Now with what
you've written I guess it's not mandatory, right? I'll try to use it where you
asked for that.

> >+      <_name>Belo Horizonte/Confins Airport</_name>
> 
> A new mention of airport

I'll try <city> tag here.

> >-      <_name>Carajas/Maraba</_name>
> >+      <_name>Carajás/Parauapebas</_name>
> 
> Is Carajas/Parauapebas two places that are near by?

No, they aren't. Carajás is the name of an airport in Parauapebas. Should I
leave it just Parauapebas?

> >-      <_name>Curitiba Aeroporto</_name>
> >+      <_name>Curitiba Airport</_name>
> 
> Another airport

Here, I've just written the word airport in English. As there's another entry
for Curitiba I left it just as it was. I'll try <city> tag.

> >-      <_name>Leite Lopes/Ribeir</_name>
> 
> Are Leite Lopes and Ribeir two places near by?

No, they aren't. Ribeir is a mispelling for Ribeirão Preto, which I included
down in the patch. Leite Lopes is an airport in Ribeirão Preto, so I left it
just Ribeirão Preto.

> >+      <_name>Manaus/Eduardo Gomes International Airport</_name>
> 
> Perhaps Manaus and Eduardo Gomes should be in a city tag.

I agree.

> >+      <!-- Translators: It's an airport in São Paulo -->
> >       <_name>Marte Civ/Mil</_name>
> 
> Do we need the Civ/Mil part? Also, perhaps it should be moved into a <city> 
> tag with Congonhas.

I don't think we really need that part. Again, agreed. I'll try <city> tag.

> >-      <_name>Porto Alegre Aero-Porto</_name>
> >+      <_name>Porto Alegre Airport</_name>
> 
> Another mention of the word Airport

Just like Curitiba.

> >+      <_name>Rio de Janeiro</_name>
> >+      <_name>Rio de Janeiro/Galeão Airport</_name>
> >+      <_name>Rio de Janeiro/Jacarepaguá Airport</_name>
> 
> Rio de Janeiro would also benefit from a <city> tag.

Agreed.


Good work you too. Thank you.
Comment 10 Danielle Madeley 2005-01-30 16:42:41 UTC
The <zone> entry in London sets a forecast zone for the entire London district.
Since that's only supported in England, the US and Australia, you won't have to
worry about it. There is a DTD for you to validate against if you want to be sure.

> > Is Carajas/Parauapebas two places that are near by?
> No, they aren't. Carajás is the name of an airport in Parauapebas. Should I
> leave it just Parauapebas?

Yep, make it Parauapebas.

Everything else seems fine now.
Comment 11 Raphael Higino 2005-01-31 01:17:22 UTC
Created attachment 36748 [details] [review]
Final patch RC1

I think now I solved all problems.

Except for 'Porto Alegre Airport' (which is the name of one of the airports in
Porto Alegre), there's no use of that word along with the city name. But don't
worry, I used <city> tag for Porto Alegre city.

I used <city> tag for Rio, São Paulo, Curitiba, Manaus and other cities too.

I really hope this one will be commited.
Comment 12 Danielle Madeley 2005-01-31 03:43:29 UTC
Comment on attachment 36748 [details] [review]
Final patch RC1

This looks fine to commit. Are you able to commit to HEAD?
Comment 13 Raphael Higino 2005-01-31 14:25:21 UTC
Yes, I am. Do you want me to commit it, or you commit?
Comment 14 Danielle Madeley 2005-01-31 14:27:30 UTC
Please commit it and close this bug.

Thanks for all your hard work.