After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 164421 - Eog session handling is broken
Eog session handling is broken
Status: RESOLVED OBSOLETE
Product: eog
Classification: Core
Component: general
3.5.x
Other All
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
: 320043 533243 537699 632559 (view as bug list)
Depends on: 79285
Blocks:
 
 
Reported: 2005-01-18 05:34 UTC by Khasim Shaheed
Modified: 2021-06-19 08:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Save restore width and height patch. (1.37 KB, patch)
2011-03-02 23:52 UTC, Ian Hands
none Details | Review
Save restore width and height patch. (forgot the eog-config-keys.h changes in previous patch) (1.98 KB, patch)
2011-03-04 17:43 UTC, Ian Hands
rejected Details | Review

Description Khasim Shaheed 2005-01-18 05:34:45 UTC
Please describe the problem:
Eog window size is varying when you logout by saving the current set up and then
login.

Steps to reproduce:
1. Launch Eog
2. Logout by saving the current set up
3. Login again


Actual results:
Eog window size is varying

Expected results:
Eog window size should remain same as before logging out

Does this happen every time?
yes

Other information:
Comment 1 Teppo Turtiainen 2005-06-26 09:54:41 UTC
EOG changes the size of the window according to the size of the image it loads.
If this is what you mean, then it's a feature, not a bug.
Comment 2 Khasim Shaheed 2005-07-18 09:18:19 UTC
No, just launch EOG(don't open any image). Log out from the current gdm
session(save the current set up). And log in using the same user account.
Observe that EOG window size changes.
Comment 3 Teppo Turtiainen 2005-07-18 14:47:14 UTC
Yes, it does seem to do that.
Comment 4 Peter McDermott 2005-07-22 17:42:34 UTC
"If this is what you mean, then it's a feature, not a bug." Its a feature that
users should be able to turn off.
Comment 5 Lucas Rocha 2006-08-11 13:36:49 UTC
*** Bug 320043 has been marked as a duplicate of this bug. ***
Comment 6 Lucas Rocha 2006-08-11 13:39:10 UTC
Also, EOG doesn't recover the its state when recovering a session. Changing summary with a better description.
Comment 7 Lucas Rocha 2008-05-15 10:38:05 UTC
*** Bug 533243 has been marked as a duplicate of this bug. ***
Comment 8 Claudio Saavedra 2008-09-01 20:35:16 UTC
*** Bug 537699 has been marked as a duplicate of this bug. ***
Comment 9 Felix Riemann 2010-11-20 11:41:43 UTC
*** Bug 632559 has been marked as a duplicate of this bug. ***
Comment 10 Ian Hands 2011-03-02 23:52:12 UTC
Created attachment 182316 [details] [review]
Save restore width and height patch.

This patch:
- stores the width and height on eog_window_dispose() in gconf.
- reads the width and height in gconf on eog_window_init().

First time working with gconf. Let me know if I need to change anything.
Comment 11 Ian Hands 2011-03-04 17:43:01 UTC
Created attachment 182502 [details] [review]
Save restore width and height patch. (forgot the eog-config-keys.h changes in previous patch)
Comment 12 Felix Riemann 2011-07-17 10:40:15 UTC
Review of attachment 182502 [details] [review]:

Hi Ian,

saving the window width and height in GConf/GSettings on exit and reloading when starting eog the next time is not exactly what is required here.
Required here is a coupling of eog with the desktop session management. This for example would have eog ask you to save your changes when you logout and possibly cancel the logout.

Theoretically it could also allow you to have eog reopen on login on a specific image, but I'm not sure if session-saving (which this is called) is actually practically possible/wanted in GNOME3.
For this we'd have to save the window size somewhere together with other data (like the images in the collection), but that wouldn't be in GSettings/GConf.
Comment 13 nodiscc 2012-07-28 13:41:47 UTC
This bug was reported against a version which is not supported any more. Developers are no longer working on this version so there will not be any bug fixes for it.
Can you please check again if the issue you reported here still happens in a recent version of GNOME and update this report by adding a comment and adjusting the 'Version' field?

Again thank you for reporting this and sorry that it could not be fixed for the version you originally used here.

Without feedback this report will be closed as INCOMPLETE after 6 weeks.
Comment 14 sworddragon2 2012-07-28 17:22:12 UTC
The bug still exists in version 3.5.3 but I'm not able to set the version in this ticket.
Comment 15 nodiscc 2012-07-28 21:36:28 UTC
Updating version for this bug, according to sworddragon2@aol.com's report.
Thanks.
Comment 16 André Klapper 2021-06-19 08:45:57 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/eog/-/issues/

Thank you for your understanding and your help.