After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 155512 - gok keyboard branching logic for dynamic gui stuff needs work
gok keyboard branching logic for dynamic gui stuff needs work
Status: RESOLVED FIXED
Product: gok
Classification: Deprecated
Component: general
unspecified
Other Linux
: Urgent critical
: ---
Assigned To: David Bolter
David Bolter
AP0
Depends on:
Blocks: 155344 155473
 
 
Reported: 2004-10-15 14:58 UTC by David Bolter
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description David Bolter 2004-10-15 14:58:59 UTC
I think this is the underlying problem to a number of bugs that have cropped up.
 I will be marking them as blocked by this.
Comment 1 David Bolter 2004-10-15 15:40:15 UTC
The fix for bug #151417 is a suspect.
Comment 2 David Bolter 2004-10-15 19:41:00 UTC
For some reason gok_spy_get_list is return NULL (inside
gok_keyboard_update_dynamic) which is odd in itself, but I'm not sure that case
is handled properly.  I wonder if this is causing the keyless gok keyboard problem.
Comment 3 David Bolter 2004-10-15 20:15:55 UTC
Bill, is this not an important TODO?

GSList* gok_spy_get_list( Accessible* paccessible)
{
	gok_log ("getting list of %d nodes\n.", g_slist_length (_priv_ui_nodes));
	/* TODO: should return a copy, with client-side incremented refs */
	return _priv_ui_nodes;
}
Comment 4 David Bolter 2004-10-15 20:19:54 UTC
Note this is a gentle question (I'm doubtful it is affecting us here).
Comment 5 David Bolter 2004-10-18 15:16:31 UTC
Note to self:
gok_main_window_change_listener needs review.  Also, the window change listener
appears to be getting called when a page tab is activated (new behaviour?). 

gok_keyboard_validate_dynamic_keys only checks for branch keys and not existing
dynamic leaf keys (e.g. button, menu item, etc.). Not sure this is correct
anymore...
Comment 6 David Bolter 2004-10-18 18:42:59 UTC
This bug report has served it's purpose.  Resolution posted
to:http://bugzilla.gnome.org/attachment.cgi?id=32740&action=view

Further work will continue on particular bugs (e.g. bug #155556)