GNOME Bugzilla – Bug 155344
GOK crashes very often while working with GOK preferences window.
Last modified: 2005-01-13 15:37:07 UTC
[Bug originalled filed by partha.pratim@wipro.com; Sun bug ID #6176853] 1.Enable Accessibility Support,logout and login again. 2.Invoke GOK and click on 'GOK' button 3.Click on 'Preferences' button and activate this window. 4.Next select 'UI Grab' from the GOK main window. 5.Work with the GOK preferences window using GOK only for sometime,click on various buttons etc. Observation: GOK crashes. Attaching the stsck trace. ----------------------------------------------------------------------------------- bash-2.05b$ pstack core core 'core' of 1489: gok fe580e54 g_type_check_instance_is_a (1, f4338, febb0754, 9c00, fec5eb9c, 9e80) + 10 febb72e4 gtk_widget_set_size_request (1, fffffffd, fffffffd, 0, a78d8, fea6e910) + 28 0002dc6c gok_keyboard_position_keys (ffffffff, fffffffd, 35, 36, 0, 0) + 1dc 00031140 gok_keyboard_on_window_resize (354e98, ffbfec18, ffffffcf, ffffff6a, 0, 32) + 15c fe55dcd8 g_closure_invoke (ffbfe9d8, ffbfe86c, 2, 10000, 0, 352c30) + 174 fe5754c8 signal_emit_unlocked_R (fe4bed2c, fe59eaf8, fe4bed3c, fe4bed28, fe59eae4, 9bd48) + b70 fe57442c g_signal_emit_valist (354e98, 9bde1, 9bd48, ffbfec0c, fe59eaf8, fe4bed34) + 7f8 fe574738 g_signal_emit (354e98, 23, 0, ffbfec18, 0, 0) + 1c febb227c gtk_widget_size_allocate (354e98, 0, 0, 0, 0, fec5eb9c) + 2ec febc2a70 gtk_window_move_resize (354e98, c1, 21c, c1, 67, 0) + 450 fe55dcd8 g_closure_invoke (ffbfefd8, ffbfee6c, 1, 18000, 0, 104428) + 174 fe57576c signal_emit_unlocked_R (1000, fe59eaf8, fe4bed3c, fe4bed28, fe59eae4, 104028) + e14 fe57442c g_signal_emit_valist (354e98, 5b, 104028, ffbff208, fe59eaf8, fe4bed34) + 7f8 fe574738 g_signal_emit (354e98, 5b, 0, fe46b8f0, 1c00, fec71d54) + 1c fea2ae24 gtk_container_idle_sizer (abac, 354e98, fffb, fec71d50, 1c00, fec5eb9c) + 88 fe455a0c g_main_dispatch (98398, fe4bec00, 0, 0, fffffffd, ffffffef) + 19c fe456f40 g_main_context_dispatch (98398, 1, 7a0558, 1, fe4bec00, 98398) + 9c fe45740c g_main_context_iterate (1, 1, 1, 98398, 983a0, d) + 454 fe457b88 g_main_loop_run (550bb0, fe4bec00, fe1b5804, 79c18, fe4aa800, fe4aa800) + 348 feeb414c bonobo_main (0, 388, ff121580, feef9198, 450b0, 0) + 6c 00044d64 main (0, ffbff4cc, 5c400, 5c400, 5c400, 5c400) + 70 00022cf8 _start (0, 0, 0, 0, 0, 0) + 108 bash-2.05b$
From comment #1 :"Work with the GOK preferences window using GOK only for sometime,click on various buttons" Does this imply that UI Grab is working for the gok preferences? Or was the basic keyboard navigation used (via gok compose)?
Created attachment 32740 [details] [review] proposed patch
Created attachment 32746 [details] [review] improved patch Improved patch removed unrelated code modification in gok-keyboard.c, improves indenting format, and includes some bulletproofing elsewhere. Awaiting review until tomorrow 10:30am EST at which time I think this fix must go in as it resolves some regressions.
Created attachment 32762 [details] [review] improved patch Made a small change inspired by Padraig's 4th comment on bug 155476.
Created attachment 32765 [details] [review] avoid empty keyboards (make sure there is at least a back key)
Created attachment 32767 [details] [review] make sure single-key keyboard will be layed out properly
Patch committed (with minor date change to Changelog).
re-opening, as Frances Keenan reports that this can still be reproduced in builds based on gok-0.11.16 (c_14 linux).
closing this one, reopening 155473