GNOME Bugzilla – Bug 153270
Should auto-hide "Leave Fullscreen" popup
Last modified: 2016-09-22 22:38:35 UTC
The Exit Fullscreen button is located in the bottom left corner, and there is sometimes problems in that it obscures text or links beneath. But according to HIG 2.0 http://developer.gnome.org/projects/gup/hig/2.0/menus.html#menus-menubar it should be placed upper right: "A Leave Fullscreen button should be placed in the upper right hand corner of the window". Now seeing that Epiphany already has a toolbar in that place, I guess it would be sane to put the Exit Fullscreen inside the toolbar? That way it won't ever interfere with the document at all. Is there a GNOME stock icon for fullscreen? Otherwise, the one used in Gstreamer's gst-player seems good. By the way, on that page it also says that Esc should exit the fullscreen mode. I don't know if that would interfere with the "Stop" action that also uses Esc. But in any case please keep F11 to do Exit as well.
Mass reassigning of Epiphany bugs to epiphany-maint@b.g.o
The problem is that when shown at the top of the screen, it will obscure the toolbar or notebook. I have a patch which will integrate the exit button in the toolbar when it's shown; but if the toolbar is hidden the exit button will obscure the notebook (and esp. the notebook arrow). This could be solved by a notebook 'action area' as proposed in gtk+ bug 116650.
chpe, i didn't think the toolbar could be hidden in full screen mode, or do you mean using lockdown keys?
According to the HIG, the button should be slid off after 5 seconds. This solves the problems described above. Other fullscreen HIG recommendations not followed by Epiphany: * The button should be labelled "Leave Fullscreen" * As said above, Esc should leave fullscreen mode * The menubar should be accessible from the keyboard as usual
spark: just hide the toolbar with Shift-Ctrl-T, as in normal mode.
chpe, can we have a slightly move discoverable way of doing this since it's pretty useful. Maybe on the context menu?
I've changed the label to "Leave Fullscreen" and moved to upper right in cvs. We're still considering auto-hide, but I'm a bit concerned about the perf impact of monitoring all mouse movements... ESC is already bound to Stop, so we cannot use that to exit fullscreen mode too. The menubar is accessiblt from fullscreen mode, with standard F10 key (or whatever key set in the control centre as menu access key).
No performance impact, you just need to connect to the enter-notify-event and leave-notify-event events of the popup window.
Mass-moving bugs from Target Milestone: 1.6 to 1.8 because of feature, UI and string freeze.
jfr worked on this but ran into some problems; clearing 1.8 target.
If the URL bar is always shown in fullscreen mode, why not add the exit fullscreen button to that bar, instead of slapping it on top of the interface where it will hamper normal usage?
Bastien, the issue now is when the url bar isn't shown, the leave fullscreen mode button sits in the top right of the desktop.
What about an auto-hiding toolbar, just like Evince shows in full-screen mode (not presentation mode)
*** Bug 340021 has been marked as a duplicate of this bug. ***
Btw the actual button doesn't follow fitt's law.
As I can see (I'm using 2.19.5) the current behaviour is exactly what the bug reporter was asking, and what was eventually proposed in this thread, so I think this should be closed (I arrived here searching for gnome-love bugs, and this is also gnome-love keyworded).
Hmmm, Cosimo is right. Any reason not to close this?
This isn't fixed; see comment 4 for what's to be done.
I could have a look at Evince code and see how it would fit Epiphany, don't you think? At least posting a patch here could help people testing it and post their comments about eventual performance issues.
I didn't know that evince had auto-hide of its toolbar ? Anyway if there is code for that, it's fine to copy it :)
I might have overlooked something in evince's code, but it looks like there's nothing explicit, so it might be due to the use of non-egg toolbars. I'll probably check that later on.
The code is in EOG, not in Evince. I'm looking through it, maybe I'll come up with a patch.
totem has an example where everything is a gtkWindow, it's just conveniently positioned around, it's pretty simple: totem-fullscreen.c
Fixed in the latest version.
No, it's not fixed. If you hide the toolbar in fullscreen mode, the Leave Fullscreen button doesn't disappear after a few seconds. Cosimo, any chance you could revisit this one?
This is fixed in the sense that the floating Leave Fullscreen button is gone, which is neat. But now the only viable way to leave fullscreen is to press F11. There should be a mouse action too, either a toolbar button similar to Firefox (but only Leave Fullscreen, no Minimize or Close) or at least a context menu Fullscreen checkitem.
(In reply to gbz from comment #26) > This is fixed in the sense that the floating Leave Fullscreen button is > gone, which is neat. But now the only viable way to leave fullscreen is to > press F11. There should be a mouse action too, either a toolbar button > similar to Firefox (but only Leave Fullscreen, no Minimize or Close) or at > least a context menu Fullscreen checkitem. Yeah I think so, but this isn't the best bug to track that in.