GNOME Bugzilla – Bug 149236
crash opening gnome-theme-manager [top_theme_dir_changed]
Last modified: 2005-02-28 15:17:37 UTC
Distribution: Fedora Core release 2 (Tettnang) Package: control-center Severity: normal Version: GNOME2.7.90 2.7.0 Gnome-Distributor: GARNOME Synopsis: crash opening gnome-theme-manager Bugzilla-Product: control-center Bugzilla-Component: theme-manager Bugzilla-Version: 2.7.0 BugBuddy-GnomeVersion: 2.0 (2.7.2) Description: Description of the crash: Opened it once with no problems. Closed it and opened it again and crash. Debugging Information: Backtrace was generated from '/home/rodd/gnome-2.7.4-test/bin/gnome-theme-manager' Using host libthread_db library "/lib/tls/libthread_db.so.1". [Thread debugging using libthread_db enabled] [New Thread -150103424 (LWP 4808)] 0x00694402 in ?? ()
+ Trace 49081
Thread 1 (Thread -150103424 (LWP 4808))
------- Bug moved to this database by unknown@bugzilla.gnome.org 2004-08-03 22:21 ------- Unknown version 2.7.0 in product control-center. Setting version to "1.4.0". Unknown platform unknown. Setting to default platform "Other". Unknown milestone "unknown" in product "control-center". Setting to default milestone for this product, '---' Setting to default status "UNCONFIRMED". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
*** Bug 152936 has been marked as a duplicate of this bug. ***
*** Bug 153998 has been marked as a duplicate of this bug. ***
Found dups, marking as new.
Seen this too: ==11350== Reading syms from /home/kmaraas/gnome28/lib/gtk-2.0/2.4.0/engines/libpixmap.so (0x1CCB2000) ==11347== ==11347== Invalid read of size 1 ==11347== at 0x8053EE0: common_icon_theme_dir_changed (gnome-theme-info.c:897) ==11347== by 0x1BEAA2C1: actually_dispatch_callback (gnome-vfs-monitor.c:271) ==11347== by 0x1C2BA1CF: g_idle_dispatch (gmain.c:3802) ==11347== by 0x1C2B70DF: g_main_context_dispatch (gmain.c:1942) ==11347== by 0x1C2B8B0C: g_main_context_iterate (gmain.c:2573) ==11347== by 0x1C2B8D8B: g_main_loop_run (gmain.c:2777) ==11347== by 0x1BC0C7F6: gtk_main (gtkmain.c:1173) ==11347== by 0x8050BE7: main (gnome-theme-manager.c:1470) ==11347== Address 0x0 is not stack'd, malloc'd or (recently) free'd ==11350== discard syms at 0x1CDCB000-0x1CDE5000 in /home/kmaraas/gnome28/lib/gtk-2.0/2.4.0/engines/libsmooth.so due to munmap() ==11347== discard syms at 0x1B958000-0x1B95B000 in /usr/lib/gconv/ISO8859-1.so due to munmap()
*** Bug 154832 has been marked as a duplicate of this bug. ***
*** Bug 158137 has been marked as a duplicate of this bug. ***
*** Bug 160594 has been marked as a duplicate of this bug. ***
After I reported this as bug 158137, I realized the problem was with the theme name. I forget exactly what was in the name that caused the crash, but it was probably something like a space, or a single quote, since it was a custom theme that I named something like "Raul's Theme". There may also have been an issue that since the theme name had special characters, the theme name didn't match the directory name (aside from whitespace).
I also get this in the gnome-vfs themes:// module, crashing nautilus and other apps.
*** Bug 161641 has been marked as a duplicate of this bug. ***
I think I've found it. Attaching a patch. There's still a leak in there and it's gotten bigger with this fix, but fixing the crash trumps the leak I guess. Jonathan was ok with me commiting this, and I've changed themes a lot with no problems since I did this.
Created attachment 36582 [details] [review] fix the crash
*** Bug 163487 has been marked as a duplicate of this bug. ***
*** Bug 163742 has been marked as a duplicate of this bug. ***
http://bugzilla.gnome.org/show_bug.cgi?id=160803#c8 The patch reduced the 100% cpu usage problem in bug 160803.
Found one more possible cause of a crash. We didn't copy the stuff into the hash in all places. Updated patch attached.
Created attachment 36600 [details] [review] updated patch Leak more crash less. If someone wants to help find the leaks that would be awesome
I can't get the crash from this bugreport anymore with the above crash. I still got the one from bug #160803 though and there's reports of leaks in both the common theme code and in the smooth engine where the latter crash also happens. Someone with knowledge of the smooth engine should probably help out find the remaining issues.
I'm going to commit this so people can test it more easily, but I'll leave this open so we can confirm this fixes the crashes for everyone.
It's still crashing left and right and also takes with it other programs sometimes. There are some crashes when changing themes also, but they could be theme related problems and not related to this. I'm marking this up to Urgent since we really can't ship with this in such a broken state. My gut feeling is that the problem could be outside of gnome-theme-info.c since not matter what I've done to reduce the possiblility of crashes in there it continues. I can get it to crash almost every time I run it in gdb, it seldomly crashes when running it from a shell directly...
*** Bug 165900 has been marked as a duplicate of this bug. ***
I can still produce this crash if I have a directory which does not have an index.theme file cd $prefix/share/themes ; mkdir test ; gnome-theme-manager => boom
Can you still reproduce this if you use gnome-vfs, gtk-engines and gnome-control-center from CVS?
Comment on attachment 36600 [details] [review] updated patch Marking the band aid as non-optimal
*** Bug 166761 has been marked as a duplicate of this bug. ***
So, this should be fixed by the new releases of gnome-vfs and gtk-engines. Can anyone who had this problem confirm this please?
Comment on attachment 36600 [details] [review] updated patch Marking this as bogus.
And marking down since there's not much work to do here except verify the fixes in other modules.
If we believe this is fixed, I'm taking it off the 2.10 list- we'll just have to grit our teeth and see what the results are from 2.10.0 ;)