After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 148370 - Support DEMANDS_ATTENTION in task list
Support DEMANDS_ATTENTION in task list
Status: RESOLVED FIXED
Product: libwnck
Classification: Core
Component: general
unspecified
Other Linux
: High normal
: ---
Assigned To: libwnck maintainers
libwnck maintainers
Depends on:
Blocks: 155909
 
 
Reported: 2004-07-24 22:02 UTC by Rob Adams
Modified: 2005-01-05 14:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add demands_attention support (9.95 KB, patch)
2004-07-24 22:03 UTC, Rob Adams 		none Details | Review
Final patch (8.49 KB, patch)
2004-07-25 18:04 UTC, Rob Adams 		none Details | Review

Description Rob Adams 2004-07-24 22:02:39 UTC 
This patch adds support for the DEMANDS_ATTENTION hint to the tasklist.  It
doesn't do any blinking for now, but rather just sets the text bold for windows
with the demands attention hint set.  I couldn't figure out how to do pango
markup in gtk menus though, so the window selector doesn't do anything special.

This does make it much nicer if a window is prevented from stealing focus and
metacity sets the DEMANDS_ATTENTION hint.
Comment 1 Rob Adams 2004-07-24 22:03:02 UTC 
Created attachment 29862 [details] [review]
add demands_attention support
Comment 2 Havoc Pennington 2004-07-25 05:19:30 UTC 
I think a cut-and-paste of eel_gtk_label_make_bold() might make this patch a lot
smaller... see what you think.

It looks good to me otherwise.
Comment 3 Rob Adams 2004-07-25 18:04:23 UTC 
Created attachment 29879 [details] [review]
Final patch

...and so it does.  Well maybe not shorter but a lot simpler.  This version has
been committed.  Do you have a suggestion for what the window selector should
do when there's a window with demands_attention set?
Comment 4 Vincent Untz 2005-01-05 14:33:07 UTC 
It's fixed. And the window selector does the same thing.