After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 138881 - Clock applet does not resize itself properly when panel height changes
Clock applet does not resize itself properly when panel height changes
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: clock
2.6.x
Other Linux
: Normal minor
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-04-02 19:07 UTC by Rob Adams
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.5/2.6


Attachments
The fix (9.00 KB, patch)
2004-04-12 09:25 UTC, Dharmaveer Singh
accepted-commit_now Details | Review

Description Rob Adams 2004-04-02 19:07:09 UTC
Put a clock applet on a horizontal panel.  Resize the panel so that the applet
shows in one row.  Now grow the panel until the clock applet can use two rows. 
The applets width stays at the width needed for one row, so there's a lot of
wasted space.  This is for the clock applet in HEAD.
Comment 1 Dharmaveer Singh 2004-04-12 09:25:07 UTC
Created attachment 26576 [details] [review]
The fix
Comment 2 Mark McLoughlin 2004-05-26 07:44:33 UTC
Patch looks good to commit, but there's no need for the comment referencing the
bug number. Just remove the comment.

Also, its

} else

not

}
else

Thanks
Comment 3 Mark McLoughlin 2004-06-02 19:41:54 UTC
The correct fix is actually to call unfix_size() when the orientation or size
changes.

2004-06-02  Mark McLoughlin  <mark@skynet.ie>

        Fix for bug #138881 - clock takes up too much width when
        you resize the panel such that the clock displays on
        two rows.

        * clock.c:
        (applet_change_orient), (applet_change_pixel_size): unfix
        the cached size when the orientation or size changes.