After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 137890 - Text tool halted when using Redo
Text tool halted when using Redo
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Tools
git master
Other All
: Normal normal
: 2.0
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks: 136740
 
 
Reported: 2004-03-22 01:23 UTC by Sven Neumann
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
suggested fix (14.32 KB, patch)
2004-03-22 01:25 UTC, Sven Neumann 		none Details | Review

Description Sven Neumann 2004-03-22 01:23:24 UTC 
The next text tool undo works quite nicely but there's an issue that is
rather annoying. When invoking a Redo the image is dirtied and the text
tool is halted. This is not obvious and it disturbs the workflow.

The obvious solution is to set tool_control->preserve to TRUE for the text
tool. There is a case however when the text tool should disconnect from the
current text layer and that's when the layer is modified by other means
than a text operation. This can be achieved by connecting to notifications
of the "modified" property of the text layer. I will attach a patch that
implements this behaviour. Please review and test.
Comment 1 Sven Neumann 2004-03-22 01:25:50 UTC 
Created attachment 25865 [details] [review]
suggested fix
Comment 2 Sven Neumann 2004-03-22 14:33:08 UTC 
2004-03-22  Sven Neumann  <sven@gimp.org>

	* app/tools/gimptexttool.[ch]: preserve the text tool on image
	changes. Instead connect to the text layer's "notify::modified"
	signal and disconnect from the layer when it is modified.
	Fixes bug #137890.