GNOME Bugzilla – Bug 135862
[wavparse] add ADPCM support
Last modified: 2004-12-22 21:47:04 UTC
With either gstreamer 0.6.4 or 0.7.4, try to use gst-launch-ext on test file from bug http://bugzilla.gnome.org/show_bug.cgi?id=107483 (it is a MS ADPCM wave file) You'll get a : ERROR: /pipeline0/wavparse0: wavparse: format 2 not handled Trying to use audiofile source is also problematic.
Not playing in gst-launch-ext isn't really a bug. However, it doesn't really play well with gst-player, either.
Created attachment 26680 [details] [review] patch from ronald to make wavparse handle adpcm the attached patch from Ronald fixes wavparse. However, it doesn't help the situation, since spider still plugs wavparse directly connected to osssink, while it should insert an ffmpeg decoder for the format. This is probably because spider sees one of the pad templates of wav parse as directly connectable to osssink, but on actual caps nego wavparse sets the adpcm mime type explicitly causing it to fail. So not putting this patch in 0.8.1 until that is resolved.
Committed, so the remaining thing is to fix spider.
Fixed in CVS by making it a sometimes pad. Workaround can be reverted once spider or another autoplugger is fixed.
Ronald, can you please add a comment in the source with that and a reference to this bug?
There is. gst-plugins/gst/wavparse/gstwavparse.c:66 GST_PAD_SOMETIMES, /* FIXME: spider */ Benjamin and me know what that means.