GNOME Bugzilla – Bug 133459
Patch: Show album cover as icon next to the song tiltle
Last modified: 2005-09-10 14:07:04 UTC
A little patch that shows the album cover for an mp3 next to the title of the song (see screenshot at http://www.wh-hms.uni-ulm.de/~mfcn/shared/rhythmbox-album_icon.png). The patch simply looks for a file "cover.jpg" (or .JPG, .gif, .GIF) in the directory of the song. The functionality is probably still improveable, but I wanted this and it works fine for me as it is :-) However if there is a chance to get this included into rhythmbox, I would put more work into it if required...
Created attachment 24073 [details] [review] patch is agains gnome-cvs from 2004-02-05, apply with patch -p0 < rhthmbox-album_icon.patch
Created attachment 24148 [details] [review] revised patch that uses gnome-vfs
Made some of the changes, that Colin Walters had proposed: the patch now uses gnome-vfs instead of assuming local uris and uses GdkPixbufLoader to get the Covers. Furthermore, it only loads images with less then 200kb.
You would really want to do that asynchronously, in case there are songs on remote machines (say NFS, SMB, etc.)
Sounds like a good idea :-) I've changed it already. As proposed I have created my own arch branch: mfcn@wh-hms.uni-ulm.de--2004 at http://www.wh-hms.uni-ulm.de/~mfcn/archive/ so I won't post any further patches here.
I do not know if it is wise to throw the album art by the title. There is a mockup on the -devel list with what I think is the best way to handle the album art.
*** Bug 110656 has been marked as a duplicate of this bug. ***
It would be nice if rhythmbox would try to download images from Amazon if it can't find a local image. http://mail.gnome.org/archives/rhythmbox-devel/2003-August/msg00225.html shows how this can be done with Amazon's XML interface (probably a bit simpler than using the SOAP interface -- at least from C code). Note that there are two typos in the code: There shouldn't be semicolons at the end of the NO_IMAGE_URL and SEARCH_URL_FORMAT defines. Also, using ImageUrlSmall is probably more appropriate for rhythmbox than ImageUrlMedium.
*** Bug 143342 has been marked as a duplicate of this bug. ***
I haven't looked at the patch, so excuse me if I repeat what is probably duplication. I would suggest an option that would show *any* image in the same directory with the .mp3/.ogg/.whatever. The reasoning is that some people (unsure of the percentage) store their files in directories by albums. I, for example, keep my album covers in the directory, but they have names like cover, rear, insert, etc. and might be .gif, .png, .jpg, etc. depending on where they come from. Great work, I love rythmbox so far! Ciao!
This can probably be closed, as it is being obsoleted by Bug 307848 Anyone has serious objections?
Right, marking dupe, you've had your chance to complain :-) *** This bug has been marked as a duplicate of 307848 ***