GNOME Bugzilla – Bug 131568
minimize all entry in rightclick menu
Last modified: 2005-01-18 21:10:26 UTC
the window list should have some entry to minimze all windows of a group. what is the window grouping usefull to if you have to cycle through different windows that could easily be minimzed at once. e.g you have a couple of nautilus windows open, it would be really neat to click on the window list entry of nautilus and select minimize all, to make way for the workspace.
Created attachment 25790 [details] [review] Proposed Patch
Created attachment 25791 [details] Screenshot of how it looks like
This enhancement is in libwnck module not really in panel. Moving to libwnck. I know gnome26 is in freeze, probably looking for GNOME28 :-) Any comments are welcome.
*** Bug 138203 has been marked as a duplicate of this bug. ***
*** Bug 128114 has been marked as a duplicate of this bug. ***
Havoc, good for 2.7.x?
*** Bug 147829 has been marked as a duplicate of this bug. ***
I am not the maintainer (which is basically a disclaimer saying that you should probably ignore me). However: Some of the changes in the patch appear to be gratuitous replacement of spaces with tabs. Why? The added code does not follow the indentation style of the rest of the code. The code adds the words "Restore all", where "restore" is not an operation that appears elsewhere in the UI. You do use the maximization icon, and you use the word maximize in the function names in the code that handle this operation. However, the operation you perform is not maximization but rather unminimization. This is /really/ confusing. It appears that you show the minimize all and restore all (i.e. "unminimize all") options at all times. Is that correct? I would expect that if all windows in the group are minimized, then the minimized all option should not be shown. I didn't check into it very closely so I may be completely wrong, but it looks like your code shows the new operations even for windows that aren't grouped. Is that correct? If so, that seems potentially confusing. This list of nitpicks looks long. I should say that the idea sounds useful and the code in general looks good.
*** Bug 155320 has been marked as a duplicate of this bug. ***
*** Bug 137755 has been marked as a duplicate of this bug. ***
See also bug 155875.
*** Bug 159286 has been marked as a duplicate of this bug. ***
*** Bug 163499 has been marked as a duplicate of this bug. ***
I also thought about implementing this. See bug 163499 My idea was to have Close All etc. at the top. In that way it's less likely that you by accident do an operation on all windows. Is anyone still working on this patch, so that it can get accepted? It would be a shame if this great patch would just be lying around overhere.
Created attachment 35853 [details] [review] Cleaned up and updated version of the original patch This updated patch takes into to account the comments of Elijah. It even corrects a minor other identation error. I chose to move the Close All, Minimize All and Unminimize All items to the top, because of the reason I mention in my previous comment. All the three items are always visible. So even if all windows are minimized there is still an Minimize All item. My reasoning for this is that otherwise the number of menu items would change. In a group some windows can be mininized and others not minimized. In that case you would need both Unminimize and Minimize. This is also in accordance with non-grouped windows, where the Move and the Resize item are visible and active when the window is minimized (maybe this is a bug and they should be disabled) I chose not to add: * Maximize All. Because I don't see why you would maximize a whole group * Roll Up All and Unroll All. Probably not used much and would make the menu you really large and ugly What do you think about all this?? BTW I noticed that the right click menu of the window list contains Rollup but the Window menu (menu you get when you click on the icon on the top left of a window) doesn't. The window menu then again has the On Top, and Move to Workspace Left/Right which the window list hasn't. This seems a bug, or was it intented?
Created attachment 35854 [details] Screenshot after the latest patch
Comment on attachment 35853 [details] [review] Cleaned up and updated version of the original patch Need spaces before parens for macros and functions, e.g. closeall () and WNCK_TASK () I'd put an underscore close_all minimize_all also Other than those last nitpicks it looks fine to me.
Created attachment 36061 [details] [review] Patch after remarks of Havoc Also corrects another format error
committed, thanks. 2005-01-18 Elijah Newren <newren@gmail.com> Patch from Jaap Haitsma to show close all and (un)minimize all options in the right click menu for grouped windows. Fixes #131568. * libwnck/tasklist.c: (wnck_task_close_all, wnck_task_unminimize_all, wnck_task_minimize_all): new functions, (wnck_task_popup_menu): add the *all options for groups windows