GNOME Bugzilla – Bug 130985
Text tool broken with respect to Undo
Last modified: 2005-01-01 21:56:10 UTC
Here are 3 testcases that outline a bug in the text tool. First of all, I have to say this maybe related to bug #124970 and bug #128818, but I do not know if this is a duplicate, so I prefer to report it. I have searched for "text" and "undo" in the bugs returned by the 5 links given on page http://www.gimp.org/devel_ver.html and found no other bug on this topic. testcase number 1 - create a new image - select text tool - click on the image to create a text layer. - In the editor window, type some text: "test" for example. The text appears as we type. - close the editor - undo: the text layer dissappear - click on the image to create a new text layer. the editor window pops up. - type some text, such as "retest": Nothing appears in the image: no text layer, no text - close the editor window - click on the image. the editor windows opens again, containing the previously entered data ("retest"). press a key, "1" for example. Suddenly appears "retest1" on a text layer in the image. testcase number 2 - create a new image - select the text tool - click the image to create a new text layer - type some text (e.g. "test") in black - change text colour to red (whatever) - change text colour to yellow (whatever) - undo 1 time : the text layer is deleted (works also if changing the font or other instead of the colour) testcase number 3. variant of 2 with outlines the bug - create a new image - as previously, create a text layer containing the text "test" - select the paint brush and paint on the background layer - select txt tool again and text layer as active layer - change the colour (or the font, etc.) of the text - press undo: instead of undoing the text modification, the paintbrush work is deleted. With respect to this behaviour, the text tool with DynText option of gimp 1.2.5 works fine. OS: Mandrake 9.2 (kernel 2.4.23pre, gtk 2.2.x) Processor: Athlon Graphic card: Matrox G400
That is known and I am pretty sure it is handled in a bug report already. Will be fixed before 2.0. Please check for duplicates and close this report accordingly.
I have searched for duplicates and have not found one. This is why I opened this bug report. I have found two bugs that _ may_ be _related to_ this one but no duplicate. To quote my original bug report: "First of all, I have to say this maybe related to bug #124970 and bug #128818, but I do not know if this is a duplicate, so I prefer to report it. I have searched for "text" and "undo" in the bugs returned by the 5 links given on page http://www.gimp.org/devel_ver.html and found no other bug on this topic."
Although the root cause of this bug is similar to that of bug #1288128, the visible effects are different and this bug report explains the problems in a better way, so I think that it deserves to be confirmed as NEW. And since we have just made a pre-release that already got a lot of public attention, I think that the known bugs should be made visible even if they will be fixed soon.
This is basically a duplicate of bug #128818. Suggest closing as DUPLICATE.
The cause is similar, the visible effects are different. Since the description of the effects is better in this bug report, I would suggest marking bug #128818 as a duplicate of this one (this is a bit backwards, but has been done before). This would be better for the pre-release users searching for known bugs.
Better than before, but not fixed yet: 2004-01-19 Michael Natterer <mitch@gimp.org> * app/tools/gimptexttool.c (gimp_text_tool_create_layer): if there is a floating selection, anchor it before adding the text layer. Fixes bug #127451. Also fixed some issues with undo. Addresses, but does not fix bug #124969 and bug #130985.
*** Bug 128818 has been marked as a duplicate of this bug. ***
Setting severity to blocker for the bugs which definitely need to be fixed before 2.0. Dave.
The current CVS version has all these test cases fixed but since there are a few issues with the new undo functionality, I'll leave this bug open until they have been fixed. I am only adding this note so people know that we are close to have the last bugs fixed for the 2.0 release.
Text undo is now implemented and seems to work fine. I've filed new bug reports for remaining issues with text undo, see bug #137766 and bug #137767. This generic report can now be closed as FIXED.