GNOME Bugzilla – Bug 129124
resize fails below certain pixel size (18 or 24?), but some applets try anyway
Last modified: 2004-12-22 21:47:04 UTC
Package: gnome-panel Severity: minor Version: 2.4.1-4 Synopsis: Resize Fails below 24 pixels, volume control weirdness Bugzilla-Product: gnome-panel Bugzilla-Component: Panel Description: Description of Problem: Using panel properties, size has no effect below 24 units, but when you get to 12 units, the volume control icon shrinks to near-invisibility. Steps to reproduce the problem: 1. Pull up panel properties dialog 2. reduce size below 24 all the way to 12 (smallest it will go). 3. Note nothing changes until the last increment, when the volume control icon suddenly turns into a bug. Actual Results: No size reduction, volume control weirdness. Expected Results: Smooth (or at least some) size reduction. How often does this happen? Every time. Additional Information: Same phenomenon seen on Fedora Core 1. ------- Bug moved to this database by unknown@bugzilla.gnome.org 2003-12-11 15:35 ------- Reassigning to the default owner of the component, gnome-panel-maint@bugzilla.gnome.org.
I'm seeing 24 with my top panel, but 18 with my bottom panel. The 'show desktop' button also does something like the volume applet. Very odd.
*** Bug 126450 has been marked as a duplicate of this bug. ***
There is no change in the panel size below 24. Certain applets like volume control, sticky notes, show desktop changes its size at 12 and becomes almost invisible. So Why not set the lower limit as 24 instead of 12. If we have to set the lower limit to 24 then GNOME_Vertigo_PANEL_XX_SMALL = 24U GNOME_Vertigo_PANEL_X_SMALL = 36U GNOME_Vertigo_PANEL_SMALL = 48U GNOME_Vertigo_PANEL_MEDIUM = 64U GNOME_Vertigo_PANEL_LARGE = 80U GNOME_Vertigo_PANEL_X_LARGE = 96U GNOME_Vertigo_PANEL_XX_LARGE = 128U Need your suggestion luis,calum,mark..
Created attachment 28043 [details] [review] Patch which sets the lower limit of the spin dialog to 24.
The above patch just sets the lower limit of the spin dialog to 24,.. It does not change the Constants in comment #3.
Comment on attachment 28043 [details] [review] Patch which sets the lower limit of the spin dialog to 24. The *actual* minimum height is worked out in calculate_minimum_height() and its not neccessarily 24.
Mark: Yes ,I saw that. But there is no change in the size of the panel and applets below 24. see comment #3. Only very few applets change their size at 12. That too they become invisible. So i set the lower limit of the size spin dialog box to 24. Is there any other solution available?
I have attached a patch to bug #144531 that solves this issue, at least for the volume control applet.
Created attachment 29121 [details] [review] patch that solves the bug for the show-desktop applet This patch makes the show-desktop follow the real panel size, and not the size given by the size hint. It solves the present bug but also the equivalent of bug #144531 for the show-desktop applet. Is there any applet left that follow the behavior of the present bug ?
Ping : can someone review and (luckily) apply this patch ?
I committed a slightly modified version of your patch. I can't verify right now that it works, but it should.
Hey Vincent, I'm getting an error on testing what's in CVS showdesktop.c: In function `applet_size_allocated': showdesktop.c:153: error: `allocation' undeclared (first use in this function) showdesktop.c:153: error: (Each undeclared identifier is reported only once showdesktop.c:153: error: for each function it appears in.) it's missing the: RCS file: /cvs/gnome/gnome-panel/applets/wncklet/showdesktop.c,v retrieving revision 1.20 diff -u -b -B -r1.20 showdesktop.c --- wncklet/showdesktop.c 4 Aug 2004 14:53:35 -0000 1.20 +++ wncklet/showdesktop.c 5 Aug 2004 18:10:15 -0000 @@ -147,6 +147,7 @@ static void applet_size_allocated (PanelApplet *applet, gint size, + GtkAllocation *allocation, ShowDesktopData *sdd) { would you like me to commit this?
Indeed, the correct fix would be : applet_size_allocated (PanelApplet *applet, - gint size, + GtkAllocation *allocation, ShowDesktopData *sdd) i.e. the "gint size" should be removed as well.
Sorry. This is fixed.
whoops, I missed that - part. Thanks to both Vincents :-) It seems to compile now and I'll check out the results a little later.