After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 120025 - Implement accessibility toolkit support
Implement accessibility toolkit support
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
2.5.x
Other Linux
: High major
: METACITY2.6.x
Assigned To: Metacity maintainers list
Metacity maintainers list
: 111934 118864 118870 120253 122310 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-08-16 16:10 UTC by Rob Adams
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (821 bytes, patch)
2003-09-09 13:27 UTC, padraig.obriain
none Details | Review
Patch to load accessibility modules into metacity (3.79 KB, patch)
2003-09-10 16:36 UTC, padraig.obriain
none Details | Review

Description Rob Adams 2003-08-16 16:10:26 UTC
Currently gnopernicus does not receive at-spi/gail events on workspace
switch, alt-tab, alt-space, etc, so no speech is possible for these events.
 This is an accessibility showstopper.

We need to figure out what is required to get metacity to support atk.
Comment 1 Rob Adams 2003-08-16 16:11:24 UTC
*** Bug 118870 has been marked as a duplicate of this bug. ***
Comment 2 Rob Adams 2003-08-16 16:11:27 UTC
*** Bug 118864 has been marked as a duplicate of this bug. ***
Comment 3 Rob Adams 2003-08-16 16:11:29 UTC
*** Bug 111934 has been marked as a duplicate of this bug. ***
Comment 4 padraig.obriain 2003-08-20 07:31:17 UTC
*** Bug 120253 has been marked as a duplicate of this bug. ***
Comment 5 bill.haneman 2003-08-21 11:49:25 UTC
with four dups against it, can we escalate the priority and/or
severity of this bug?  thanks.

possible solutions would be 

(1) for metacity's focus-cycling to be changed such that the windows
in the list are _actually focussed_ during the TAB cycle rather than
just having the metacity window list popup highlight them, or;

(2) make metacity connect to at-spi-registryd and have it's popup send
ATK events, so that the names of the highlighted toplevels were spoken
by gnopernicus in the same way other active widgets are spoken when
focussed (means metacity's popup would probably have to grab focus
during the alt-tab cycling process)


perhaps others.
Comment 6 Havoc Pennington 2003-08-29 14:42:28 UTC
You can set priority and severity to whatever you want, 
however I still don't have time to look at it right now. ;-)
If someone else would like to, please do.

I prefer the second approach (sending proper events) rather than 
actually focusing the windows as you go through them.
Comment 7 padraig.obriain 2003-09-09 13:26:12 UTC
There are two separate issues:

1) Determining whether accessibility support should be enabled in
metacity.

2) Reporting chnage of window name when Atl+Tab or Ctrl+Alt+Tab is
pressed.

I will attach a patch to metacity for the sewcond issue. To test it
with gnopernicus, pening resolution of issue 1, one would bnned to set
the environment variable GTK_MODULES to "gail:atk-bridge" and restart
metacity by "metacity --replace".

Regarding issue 1, the options seem to be to either make metacity a
GNOME application or add to metacity code which checks the setting of
the accessibility GConf key and loads the accessibility modules.
Comment 8 padraig.obriain 2003-09-09 13:27:50 UTC
Created attachment 19824 [details] [review]
Proposed patch
Comment 9 padraig.obriain 2003-09-10 16:36:19 UTC
Created attachment 19845 [details] [review]
Patch to load accessibility modules into metacity
Comment 10 Rob Adams 2003-09-15 06:09:27 UTC
*** Bug 122310 has been marked as a duplicate of this bug. ***
Comment 11 Rob Adams 2003-09-20 05:05:17 UTC
those patches look good to me.  We should probably go ahead and commit
those before we branch for gnome 2.4.  I assume that calling the
atk_object_set_role stuff doesn't cause problems if accessibility
modules aren't loaded?
Comment 12 padraig.obriain 2003-09-22 10:13:13 UTC
Calling atk_object_set_role will not cause a problem if accessibility
modules are not loaded.

Should I interpret your comments as permission to commit the patches?
Comment 13 Rob Adams 2003-09-22 15:29:50 UTC
no, sorry.  Havoc needs to approve.  I was just telling Havoc I think
that he should.
Comment 14 Havoc Pennington 2003-09-22 22:08:57 UTC
First patch looks fine.

Second patch also looks fine (for now) with two caveats:

 - it might be nice to run it by the release team, as technically 
   it's a feature

 - it is totally broken, it looks like bug #117236 is the real fix

I'd like to open a new metacity bug with a dependency on 117236 to
remove this code again after we've done things more reasonably.
Comment 15 Havoc Pennington 2003-09-26 16:46:34 UTC
Please go ahead and commit these patches, will be making a 2.6.2 soon.
Comment 16 padraig.obriain 2003-09-26 17:04:44 UTC
Patchse committed to CVS HEAD.
Comment 17 Havoc Pennington 2003-09-27 15:20:06 UTC
Thanks. I filed bug #123372 to clean up the hack patch #2 by GTK+ 2.4.