After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 119825 - Alt-F1 always opens main menu on first head
Alt-F1 always opens main menu on first head
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: panel
2.3.x
Other other
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
: 137425 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-08-13 22:19 UTC by Dan Siemon
Modified: 2005-01-12 04:31 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
Patch fixes the bug (3.48 KB, patch)
2005-01-11 14:21 UTC, Arvind S N
accepted-commit_now Details | Review

Description Dan Siemon 2003-08-13 22:19:19 UTC
Distribution: Red Hat Linux release 9 (Shrike)
Package: gnome-panel
Severity: normal
Version: GNOME2.3.6 2.3.x
Gnome-Distributor: GARNOME
Synopsis: Alt-F1 always opens main menu on first head
Bugzilla-Product: gnome-panel
Bugzilla-Component: Panel
Bugzilla-Version: 2.3.x
Description:
Description of Problem:
On my multihead configuration (no xinerama) if I hit Alt-F1 when I have
a window focused on the second head the main menu opens on the first
head. Make it impossible to open apps in the second head with the
keyboard.

Steps to reproduce the problem:
1. Focus window on second head
2. Hit Alt-F1 (or other main menu key binding)




------- Bug moved to this database by unknown@bugzilla.gnome.org 2003-08-13 18:19 -------

Reassigning to the default owner of the component, gnome-panel-maint@bugzilla.gnome.org.

Comment 1 Fernando Herrera 2004-02-12 09:29:46 UTC
Confirmed here
Comment 2 Tim Herold 2004-02-12 10:03:36 UTC
I'm running gnome-panel 2.5.3.1 from fedora-devel and I can confirm
this. It seems that Alt-F1 will only pop up on whichever menu-bar
existed first. I deleted them both, create on on head2 and then one on
head1, and then it will only pop up on head2; delete and recreate the
on on head2 and it will only pop up there. This is with the nvidia
binary-only driver in multiple sreen (not xinerama or twinview) mode,
if that matters.
Comment 3 Vincent Untz 2004-03-16 22:15:52 UTC
*** Bug 137425 has been marked as a duplicate of this bug. ***
Comment 4 Arvind S N 2005-01-11 14:21:30 UTC
Created attachment 35828 [details] [review]
Patch fixes the bug

initially thought of forcing the GdkScreen* to be passed for
panel_applet_get_by_type () but thought against it. Passing NULL should also be
okay. But you guys think the below should just do ?

-		if (info->type == object_type)
+		if (info->type == object_type && screen ==
gtk_widget_get_screen (info->widget))
			return info;
Comment 5 Vincent Untz 2005-01-11 18:00:02 UTC
Comment on attachment 35828 [details] [review]
Patch fixes the bug

Arvind: I think that passing NULL is okay. I'm just wondering if having a
fallback which is not on the right screen is a good thing or not. Something
like:

{
	AppletInfo *fallback;
	GSList	   *l;

	fallback = NULL;

	for (l = registered_applets; l; l = l->next) {
		AppletInfo *info = l->data;

		if (info->type == object_type) {
			if (screen) {
				if (screen == gtk_widget_get_screen
(info->widget))
					return info;
				else if (!fallback)
					fallback = info;
			} else
				return info;
		}
	}

	return fallback;
}

I'm not a multihead user, so I don't know if this behaviour can be expected.
Please commit your patch with or without my proposition :-) (just remove the
new empty line you added in panel_applet_get_by_type())

Thanks
Comment 6 Arvind S N 2005-01-12 04:23:32 UTC
vincent: If on one screen we have a main menu and on another we have a menu bar,
with the fallback mechanism we would always get the menbar irrespective of which
screen alt-F1 is done. So, have not done the fallback. Have checked in the patch. 

But it does raise a question of what should user expect when doing a Alt-F1 when
he has a menubar and main menu on the panel. Currently it always pops up the
menu bar.